Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Limb darkening for joint fits not using different values for the different visits/channels #743

Open
2 tasks done
erinmmay opened this issue Feb 11, 2025 · 0 comments · May be fixed by #744
Open
2 tasks done

[Bug]: Limb darkening for joint fits not using different values for the different visits/channels #743

erinmmay opened this issue Feb 11, 2025 · 0 comments · May be fixed by #744
Assignees
@taylorbell57 @erinmmay
Labels
bug Something isn't working LC Fit NIRISS

Comments

@erinmmay
Copy link
Collaborator

erinmmay commented Feb 11, 2025 •
edited by taylorbell57
Loading

FAQ check

  • Yes, I checked the FAQ and my question has not been addressed.

Instrument

Light curve fitting (Stages 4-6)

What happened?

In AstroModel limb darkening does not account for the channel number when doing multwhite fits. As a result, when fixing to the exotic-ld calculated values, both "visits" end up using the same values. This impacts joint fits between G395H NRS1/NRS2 and NIRISS SOSS Order 1 and Order 2.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@erinmmay erinmmay added the bug Something isn't working label Feb 11, 2025
@erinmmay erinmmay linked a pull request Feb 11, 2025 that will close this issue
Open
@taylorbell57 taylorbell57 linked a pull request Feb 11, 2025 that will close this issue
fixing LD bug for joint fits #744
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taylorbell57 taylorbell57

@erinmmay erinmmay

Labels
bug Something isn't working LC Fit NIRISS
Projects
Road to v2.0
Status: To do
Stage 5: Light Curve Fitting
Status: To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixing LD bug for joint fits erinmmay/Eureka
5 participants
@afeinstein20 @taylorbell57 @erinmmay @meganmansfield @evamariaa