Some minor fixes #962
Open
Some minor fixes #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapyElGringo
requested changes
May 30, 2023
| uuid: string, | ||
| ...args: any[] | ||
| ) { | ||
| if (incompatibleExtensions.includes(uuid)) return; | ||
| // eslint-disable-next-line prefer-rest-params | ||
| originalFunction!.apply(this, arguments); | ||
| await originalFunction!.apply(this, arguments); |
There was a problem hiding this comment.
We should return the orginalFunction result instead of await
There was a problem hiding this comment.
That's okay. Should I add an undefined to the return in line 28, too?
There was a problem hiding this comment.
Returning nothing is similar as returning undefined
…nction The original method is defined as async. Hence, we need to pass through the return value of the originalFunction and in case of an early return, we need to return a resolved promise. https://github.com/GNOME/gnome-shell/blob/ba43c6191798dd07f66693ec90e2808ec9954e5c/js/ui/extensionSystem.js#L217
With parallel make execution the targets are run in parallel and you get the conflict: ``` % make compile rm -rf dist cp -r schemas dist mkdir dist glib-compile-schemas dist/schemas/ mkdir: cannot create directory ‘dist’: File exists ```
There are some changes in 4.8 and 4.9 they gives errors while compiling. Hence, pin the version to 4.6.x.
jo-so
force-pushed
the
disable-modules-async
branch
from
b08a10e
to
15ff308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.