Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix titlebar visibility on gnome44+ #977

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Fix titlebar visibility on gnome44+ #977

merged 3 commits into from
Sep 13, 2023

Conversation

PapyElGringo
Copy link
Collaborator

Fix xlib api change on recent version

@PapyElGringo PapyElGringo mentioned this pull request Sep 11, 2023
Closed
HalfVoxel
HalfVoxel approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@HalfVoxel HalfVoxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_MOTIF_WM_HINTS = 0 seems to be documented as showing no decorations at all.
I'd like to see a source (ideally included as a comment) for where the new value comes from.

@PapyElGringo
Copy link
Collaborator Author

It's seems that removing only the titlebar doesn't work and it's needed to remove all the decoration. But since we are doing it only on maximized window it's fine. The value come from the research of other users in issue #964

@HalfVoxel
Copy link
Contributor

Does setting it to zero also work in earlier versions of gnome?

@PapyElGringo
Copy link
Collaborator Author

Does setting it to zero also work in earlier versions of gnome?

Probably but can't really test it :(

@HalfVoxel
Copy link
Contributor

I'd be nicer without the version check.
WM_HINTs=2 is a border around the window. I haven't really seen this border at all, and I don't think we'd want one anyway. So maybe try removing it also for earlier versions.

@PapyElGringo
Copy link
Collaborator Author

Yeah done

@PapyElGringo PapyElGringo merged commit a322939 into main Sep 13, 2023
1 check failed
@PapyElGringo PapyElGringo deleted the fix-964 branch September 13, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalfVoxel HalfVoxel HalfVoxel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PapyElGringo @HalfVoxel