Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokenizer files search on HunggingFace #1618

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix tokenizer files search on HunggingFace #1618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix tokenizer files search on HunggingFace
  • Loading branch information
@maikereis
maikereis committed Feb 5, 2025
commit 312193ac757d7382577ffe05efe3c93195685134
46 changes: 30 additions & 16 deletions unsloth/models/loader.py
View file
Original file line number Diff line number Diff line change
@@ -245,15 +245,22 @@ def from_pretrained(
)
pass

# Check if this is local model since the tokenizer gets overwritten
if os.path.exists(os.path.join(old_model_name, "tokenizer_config.json")) and \
os.path.exists(os.path.join(old_model_name, "tokenizer.json")) and \
os.path.exists(os.path.join(old_model_name, "special_tokens_map.json")):

tokenizer_name = old_model_name
# Check if this is a local model or on Hugging Face
if os.path.isdir(old_model_name): # Check if old_model_name is a local directory
# Check for tokenizer files locally
tokenizer_files_exist = all(
os.path.exists(os.path.join(old_model_name, file))
for file in ["tokenizer_config.json", "tokenizer.json", "special_tokens_map.json"]
)
tokenizer_name = old_model_name if tokenizer_files_exist else None
else:
tokenizer_name = None
pass
# Check for tokenizer files on Hugging Face
fs = HfFileSystem(token=token)
tokenizer_files_exist = all(
fs.exists(f"{old_model_name}/{file}")
for file in ["tokenizer_config.json", "tokenizer.json", "special_tokens_map.json"]
)
tokenizer_name = old_model_name if tokenizer_files_exist else None

model, tokenizer = dispatch_model.from_pretrained(
model_name = model_name,
@@ -500,15 +507,22 @@ def from_pretrained(
pass
if do_logging: redirector.close()

# Check if this is local model since the tokenizer gets overwritten
if os.path.exists(os.path.join(old_model_name, "tokenizer_config.json")) and \
os.path.exists(os.path.join(old_model_name, "tokenizer.json")) and \
os.path.exists(os.path.join(old_model_name, "special_tokens_map.json")):

tokenizer_name = old_model_name
# Check if this is a local model or on Hugging Face
if os.path.isdir(old_model_name): # Check if old_model_name is a local directory
# Check for tokenizer files locally
tokenizer_files_exist = all(
os.path.exists(os.path.join(old_model_name, file))
for file in ["tokenizer_config.json", "tokenizer.json", "special_tokens_map.json"]
)
tokenizer_name = old_model_name if tokenizer_files_exist else None
else:
tokenizer_name = None
pass
# Check for tokenizer files on Hugging Face
fs = HfFileSystem(token=token)
tokenizer_files_exist = all(
fs.exists(f"{old_model_name}/{file}")
for file in ["tokenizer_config.json", "tokenizer.json", "special_tokens_map.json"]
)
tokenizer_name = old_model_name if tokenizer_files_exist else None

model, tokenizer = FastBaseVisionModel.from_pretrained(
model_name = model_name,