Optimize rl #2065
Open
Optimize rl #2065
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync local repository with remote update
…mbedding training code to be more concise in llama.py - Remove duplicate functools import in vision.py - Clean up unnecessary pass statements
unsloth/models/llama.py
Outdated
| pass | ||
| for get_embeddings_fn in ( | ||
| model.get_input_embeddings, | ||
| model.get_output_embeddings): |
There was a problem hiding this comment.
Wouldn't this result in an error if get_input_embeddings or get_output_embeddings aren't defined for model?
There was a problem hiding this comment.
yes i think you might be right
NinoRisteski
commented
Mar 18, 2025
unsloth/models/llama.py
Outdated
| pass | ||
| for get_embeddings_fn in ( | ||
| model.get_input_embeddings, | ||
| model.get_output_embeddings): |
There was a problem hiding this comment.
yes i think you might be right
unsloth/models/llama.py
Outdated
| pass | ||
| for get_embeddings_fn in ( | ||
| model.get_input_embeddings, | ||
| model.get_output_embeddings): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance in RL module