[JEWEL-845] Add Context Menu to External Links #3107

DanielSouzaBertoldi · 2025-06-27T16:32:21Z

Context

Important

For the popup to render correctly outside the row bounds in the SwingComparisonTabPanel we need #3105 merged, however it's not a prerequesite for us to open this PR.

Currently, our ExternalLink implementation doesn't show a context menu with the default action group from IntelliJ BrowserLink component (see screenshot below). This PR makes the necessary changes to show such context menu for external links only.

Main Changes

Created a LabelProvider interface which both IDE and standalone versions will implement to return the action action label.
Created a BridgeUriHandler class which implements UriHandler since in IDE we need to call IntelliJ's BrowserUtil.browse() function.
Created a new ExternalLink overload where clicking the element automatically opens the given link and also displays a ContextMenu. It also has a new parameter link which users can use to specify the actual link from the text.
This PR also fixes a weird visual bug in the Links row in SwingComparisonPanel.

Evidences

Right clicking external link

IDE	Stand-alone
Screen.Recording.2025-07-07.at.10.39.49.mov	Screen.Recording.2025-07-07.at.10.37.43.mov

Using a valid browser link

IDE	Stand-alone
Screen.Recording.2025-07-07.at.10.57.03.mov	Screen.Recording.2025-07-07.at.10.42.26.mov

Using an empty string

IDE	Stand-alone
Screen.Recording.2025-07-07.at.10.59.07.mov	Screen.Recording.2025-07-07.at.11.00.07.mov

Release notes

New features

ExternalLink component now displays a context menu with two default options when right-clicking the link: open in browser and copy link address

platform/jewel/ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/BridgeLabelProvider.kt

platform/jewel/ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/BridgeUriHandler.kt

.../ide-plugin/src/main/kotlin/org/jetbrains/jewel/samples/ideplugin/SwingComparisonTabPanel.kt

platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Link.kt

...rm/jewel/ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/theme/SwingBridgeTheme.kt

platform/jewel/ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/BridgeLabelProvider.kt

platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/util/LabelProvider.kt

platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Link.kt

...el/samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Links.kt

DanielSouzaBertoldi · 2025-07-07T14:12:17Z

platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/ContextMenu.kt

@@ -119,7 +119,7 @@ public class ContextSubmenu(label: String, public val submenu: () -> List<Contex

 public class ContextMenuItemOption(
    public val icon: IconKey? = null,
-    public val actionType: ContextMenuItemOptionAction,
+    public val actionType: ContextMenuItemOptionAction? = null,


The actionType parameter (which is used to map to a shortcut hint) should've been optional, my bad. You can have an item with an icon but no shortcut or vice versa.

DanielSouzaBertoldi · 2025-07-07T14:13:29Z

platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Menu.kt

@@ -167,7 +167,9 @@ public fun MenuContent(
    val selectableItems = remember(items) { items.filterIsInstance<MenuSelectableItem>() }

    val anyItemHasIcon = remember { selectableItems.any { it.iconKey != null } }
-    val anyItemHasKeybinding = remember { selectableItems.any { it.keybinding != null || it.itemOptionAction != null } }
+    val anyItemHasKeybinding = remember {
+        selectableItems.any { it.keybinding?.isNotEmpty() == true || it.itemOptionAction != null }


Another minor mistake from the previous PR: the keybinding parameter will always be an empty set. So we shouldn't check if it's null, but if it's not empty.

DanielSouzaBertoldi · 2025-07-07T14:14:23Z

...nt-ui-standalone/src/main/kotlin/org/jetbrains/jewel/intui/standalone/IntUiStringProvider.kt

+public class IntUiStringProvider : StringProvider {
+    override fun fetchStringFromKey(key: String): String =
+        when (key) {
+            "action.text.open.link.in.browser" -> "Open Link in Browser"
+            "action.text.copy.link.address" -> "Copy Link Address"
+            else -> ""
+        }
+}


Ideally we should have a more robust architecture to map an label key to its actual string representation, but that's outside the scope of this PR.

If this approach is fine for everybody, I'll create an issue in our board about improving this.

rock3r · 2025-07-07T15:32:34Z

@DanielSouzaBertoldi please add release notes... and check if there are conflicts — GitHub seems very confused :D

platform/jewel/ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/BridgeUriHandler.kt

rock3r · 2025-07-07T15:38:10Z

platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/util/StringProvider.kt

+import org.jetbrains.jewel.foundation.InternalJewelApi
+
+@InternalJewelApi
+public interface StringProvider {


Please add KDoc. Also, I'd name this something like MessageResourceResolver as it seems to be what it does in the IDE version, but am open to alternatives.

Honestly I'm kinda bad in coming up with names but I like your suggestion, it's way more specific and direct. @faogustavo what do you think?

platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/util/StringProvider.kt

...nt-ui-standalone/src/main/kotlin/org/jetbrains/jewel/intui/standalone/IntUiStringProvider.kt

...form/jewel/ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/BridgeStringProvider.kt

platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Link.kt

[JEWEL-845] Add Context Menu to External Links Updating branch now that JetBrains#3091 merged update api dumps applying pr suggestions reran apichecktest add KDoc to MessageResourceResolver add KDoc to MessageResourceResolver undo sample xml run config

DanielSouzaBertoldi marked this pull request as draft June 27, 2025 16:32

DanielSouzaBertoldi self-assigned this Jun 27, 2025

DanielSouzaBertoldi added the Jewel label Jun 27, 2025

DanielSouzaBertoldi requested a review from faogustavo June 27, 2025 16:33

DanielSouzaBertoldi commented Jun 27, 2025

View reviewed changes

platform/jewel/ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/BridgeLabelProvider.kt Outdated Show resolved Hide resolved

DanielSouzaBertoldi commented Jun 27, 2025

View reviewed changes

platform/jewel/ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/BridgeUriHandler.kt Outdated Show resolved Hide resolved

DanielSouzaBertoldi commented Jun 27, 2025

View reviewed changes

.../ide-plugin/src/main/kotlin/org/jetbrains/jewel/samples/ideplugin/SwingComparisonTabPanel.kt Show resolved Hide resolved

DanielSouzaBertoldi commented Jun 27, 2025

View reviewed changes

platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Link.kt Outdated Show resolved Hide resolved

faogustavo reviewed Jul 3, 2025

View reviewed changes

DanielSouzaBertoldi force-pushed the dsb/JEWEL-845 branch 2 times, most recently from 5f30676 to 4fdae8a Compare July 7, 2025 14:10

DanielSouzaBertoldi commented Jul 7, 2025

View reviewed changes

DanielSouzaBertoldi requested a review from rock3r July 7, 2025 14:15

DanielSouzaBertoldi marked this pull request as ready for review July 7, 2025 14:15

DanielSouzaBertoldi force-pushed the dsb/JEWEL-845 branch from b949d49 to 4a00c9d Compare July 7, 2025 14:18

rock3r reviewed Jul 7, 2025

View reviewed changes

DanielSouzaBertoldi force-pushed the dsb/JEWEL-845 branch from 3bac839 to ec04122 Compare July 8, 2025 14:48

DanielSouzaBertoldi force-pushed the dsb/JEWEL-845 branch from 37c3a53 to 8eb8868 Compare July 8, 2025 16:20

DanielSouzaBertoldi requested review from faogustavo and rock3r July 8, 2025 16:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[JEWEL-845] Add Context Menu to External Links #3107

[JEWEL-845] Add Context Menu to External Links #3107

DanielSouzaBertoldi commented Jun 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DanielSouzaBertoldi Jul 7, 2025 •

edited

Loading

Uh oh!

DanielSouzaBertoldi Jul 7, 2025

Uh oh!

DanielSouzaBertoldi Jul 7, 2025 •

edited

Loading

Uh oh!

rock3r commented Jul 7, 2025

Uh oh!

Uh oh!

rock3r Jul 7, 2025

Uh oh!

DanielSouzaBertoldi Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[JEWEL-845] Add Context Menu to External Links #3107

Are you sure you want to change the base?

[JEWEL-845] Add Context Menu to External Links #3107

Conversation

DanielSouzaBertoldi commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Main Changes

Evidences

Right clicking external link

Using a valid browser link

Using an empty string

Release notes

New features

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DanielSouzaBertoldi Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielSouzaBertoldi Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

DanielSouzaBertoldi Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rock3r commented Jul 7, 2025

Uh oh!

Uh oh!

rock3r Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

DanielSouzaBertoldi Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DanielSouzaBertoldi commented Jun 27, 2025 •

edited

Loading

DanielSouzaBertoldi Jul 7, 2025 •

edited

Loading

DanielSouzaBertoldi Jul 7, 2025 •

edited

Loading