[JEWEL-640] Display Placeholders for Undecorated TextField/TextArea #3111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSouzaBertoldi
force-pushed
the
dsb/JEWEL-640
branch
from
b1c4f67 to
9497beb
Compare
faogustavo
reviewed
Jul 1, 2025
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/InputField.kt
Show resolved
Hide resolved
faogustavo
approved these changes
Jul 3, 2025
rock3r
reviewed
Jul 7, 2025
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/TextArea.kt
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/TextField.kt
Show resolved
Hide resolved
platform/jewel/ui/src/main/kotlin/org/jetbrains/jewel/ui/component/TextField.kt
Show resolved
Hide resolved
lint fixes DRY DRY
DanielSouzaBertoldi
force-pushed
the
dsb/JEWEL-640
branch
from
9497beb to
7d0af00
Compare
|
@DanielSouzaBertoldi please add the release notes :) |
rock3r
approved these changes
Jul 7, 2025
|
Ready to merge |
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
closes #3111 GitOrigin-RevId: fcba8a712db460d321f2428f13eaac3ee2d4ebca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently our
TextField/TextAreacomposables don't show placeholder for undecorated versions. This PR fixes this.Main Changes
TextFieldandTextAreasamples to also have an undecorated example.TextAreaContentWrapperto remove code duplication between undecorated and decorated versions ofTextArea.NoTextAreaDecoratorcomposable to expect optional placeholder data (just likeTextAreaDecorator) and added a Box so that we can show the placeholder on top of theTextAreaarea.UndecoratedTextFieldDecorationBoxthat also has a Box just like the TextArea version, where we can place the placeholder on top.Evidences
Standalone
TextField
Screen.Recording.2025-07-01.at.11.24.08.mov
Screen.Recording.2025-07-01.at.11.09.11.mov
TextArea
Screen.Recording.2025-07-01.at.11.23.29.mov
Screen.Recording.2025-07-01.at.11.07.16.mov
IDE
TextField
Screen.Recording.2025-07-01.at.11.26.32.mov
Screen.Recording.2025-07-01.at.11.13.59.mov
TextArea
Screen.Recording.2025-07-01.at.11.26.06.mov
Screen.Recording.2025-07-01.at.11.13.29.mov
Release notes
Bug fixes
TextFieldandTextAreamarked as undecorated now show placeholders (if they have any).