Skip to content

remove outdated performance warning from readme #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oscardssmith
Copy link
Member

As of #51 this code should be generating fast code on supported hardware.

As of #51 this code should be generating fast code on supported hardware.
@oscardssmith oscardssmith requested a review from mkitti May 30, 2025 16:53
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (2ddcc84) to head (670aa9e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files           3        3           
  Lines         197      197           
=======================================
  Hits          191      191           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkitti
Copy link
Contributor

mkitti commented May 30, 2025

Should we add a note that Core.BFloat16 support began in Julia 1.11 with hardware support on Intel processors?

Perhaps we could also document BFloats16.llvm_storage and BFloats16.llvm_arithmetic as well or otherwise provide an interface for them?

Copy link
Contributor

@mkitti mkitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should comment that hardware support begins with Julia 1.11.

Co-authored-by: Mark Kittisopikul <mkitti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants