-
Notifications
You must be signed in to change notification settings - Fork 9
Feat/dev portal customizations #2019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kongdeveloper ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions. I also pushed a commit to add this to the Dev Portal landing page (I removed a link and added this one, so I thought a commit would be easier than explaining).
I'd like to see links to the customization landing page in the related links of the following pages:
- /dev-portal/pages-and-content/
- /dev-portal/custom-domains/
- /dev-portal/portal-customization/
- /dev-portal/portal-settings/
app/_landing_pages/dev-portal/customizations/dev-portal-customizations.yaml
Outdated
Show resolved
Hide resolved
app/_landing_pages/dev-portal/customizations/dev-portal-customizations.yaml
Outdated
Show resolved
Hide resolved
app/_landing_pages/dev-portal/customizations/dev-portal-customizations.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
@cloudjumpercat - I added links in these pages and split the cards into groups of 3 and 2 on the customizations landing page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just left one suggestion to fix one of the column_count.
app/_landing_pages/dev-portal/customizations/dev-portal-customizations.yaml
Outdated
Show resolved
Hide resolved
…izations.yaml Co-authored-by: Diana <75819066+cloudjumpercat@users.noreply.github.com>
Description
Adds a signpost landing page for dev portal customizations.
Preview Links
https://deploy-preview-2019--kongdeveloper.netlify.app/dev-portal/customizations/dev-portal-customizations/
Checklist
description
entry in frontmatter.