-
Notifications
You must be signed in to change notification settings - Fork 607
feat(translator): Generate KongConfigurationTranslationFailed event when algorithm=sticky-sessions and kong version < 3.11 #7538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7538 +/- ##
=======================================
- Coverage 77.4% 77.4% -0.1%
=======================================
Files 221 221
Lines 25573 25588 +15
=======================================
+ Hits 19808 19818 +10
- Misses 4755 4758 +3
- Partials 1010 1012 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I believe there are two points that need to be addressed here: in addition to not supporting the Of course, for the checks on the last two fields, we might be able to avoid them through a CEL rule. |
AFAICT we can't use CEL for these because we don't know the Kong version used in the CEL context. We only know it in runtime. |
You are right. @pmalek However, I also submitted a PR to add a CEL rule for it. I will be unavailable for the next few days, so if you think it's valuable, you can merge that PR as well. |
03fca2e
to
bdfeb73
Compare
2e6b5c7
to
91e9a00
Compare
…ky-sessions and kong version < 3.11
cca4cad
to
b6d72d6
Compare
What this PR does / why we need it:
When
KongUpstreamPolicy
set algorithm tosticky-sessions
and Kong gateway version < 3.11, generate aKongConfigurationTranslationFailed
event for services using theKongUpstreamPolicy
and do not override translatedupstream
byKongUpstreamPolicy
.Which issue this PR fixes:
closes #7537
Special notes for your reviewer:
Generation of event for Kong Gateway
< 3.11.0
is covered by dedicated envtestTestStickySessionsNotSupportedEventGeneration
. Big general envtestTestConfigErrorEventGenerationInMemoryMode
to pass has to detect this event too, because3.11.0
is not released yet, so there is no support. But3.11.0
is around the corner, so when it is updated, this test will fail, and someone needs to adjust it as described in the TODO to cover the situation of not generating this event. There is rather no point in introducing some machinery for testing it now. Proper behavior has been tested manually with the release candidate of 3.11.0, so the update will go smoothlyPR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR