Skip to content

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Jun 25, 2025

What this PR does / why we need it:

Remove CRD type bindings under /pkg/apis and clientsets under /pkg/clientset that have been deprecated since 3.4.0.

Remove linters, Makefile, etc., related configs.

Document inCHANGELOG.md path to move forward for someone who may still use it.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@programmer04 programmer04 added this to the KIC v3.5.x milestone Jun 25, 2025
@programmer04 programmer04 self-assigned this Jun 25, 2025
@programmer04 programmer04 added area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. refactor labels Jun 25, 2025
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.2%. Comparing base (b87927a) to head (8b4400a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #7540     +/-   ##
=======================================
- Coverage   77.5%   77.2%   -0.4%     
=======================================
  Files        221     221             
  Lines      25573   25573             
=======================================
- Hits       19826   19746     -80     
- Misses      4740    4810     +70     
- Partials    1007    1017     +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@programmer04 programmer04 marked this pull request as ready for review June 25, 2025 11:21
@programmer04 programmer04 requested a review from a team as a code owner June 25, 2025 11:21
@programmer04 programmer04 enabled auto-merge June 25, 2025 12:02
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that with this removal we can also get rid of

CLIENT_GEN_VERSION = $(shell $(YQ) -ojson -r '.kube-code-generator' < $(TOOLS_VERSIONS_FILE))
CLIENT_GEN = $(PROJECT_DIR)/bin/installs/kube-code-generator/$(CLIENT_GEN_VERSION)/bin/client-gen
.PHONY: client-gen
client-gen: mise yq ## Download client-gen locally if necessary.
@$(MAKE) mise-plugin-install DEP=kube-code-generator
@$(MAKE) mise-install DEP_VER=kube-code-generator@$(CLIENT_GEN_VERSION)

and

# renovate: datasource=github-tags depName=kubernetes/code-generator
kube-code-generator: "0.33.1"

Otherwise 👍

@programmer04 programmer04 added this pull request to the merge queue Jun 27, 2025
Merged via the queue into main with commit c441732 Jun 27, 2025
42 checks passed
@programmer04 programmer04 deleted the rm-crds branch June 27, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. refactor size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants