-
Notifications
You must be signed in to change notification settings - Fork 607
chore(refactor)!: remove deprecated CRD type bindings and clientsets #7540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7540 +/- ##
=======================================
- Coverage 77.5% 77.2% -0.4%
=======================================
Files 221 221
Lines 25573 25573
=======================================
- Hits 19826 19746 -80
- Misses 4740 4810 +70
- Partials 1007 1017 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that with this removal we can also get rid of
kubernetes-ingress-controller/Makefile
Lines 89 to 94 in c46527e
| CLIENT_GEN_VERSION = $(shell $(YQ) -ojson -r '.kube-code-generator' < $(TOOLS_VERSIONS_FILE)) | |
| CLIENT_GEN = $(PROJECT_DIR)/bin/installs/kube-code-generator/$(CLIENT_GEN_VERSION)/bin/client-gen | |
| .PHONY: client-gen | |
| client-gen: mise yq ## Download client-gen locally if necessary. | |
| @$(MAKE) mise-plugin-install DEP=kube-code-generator | |
| @$(MAKE) mise-install DEP_VER=kube-code-generator@$(CLIENT_GEN_VERSION) |
and
kubernetes-ingress-controller/.tools_versions.yaml
Lines 1 to 2 in 5ed1655
| # renovate: datasource=github-tags depName=kubernetes/code-generator | |
| kube-code-generator: "0.33.1" |
Otherwise 👍
What this PR does / why we need it:
Remove CRD type bindings under
/pkg/apisand clientsets under/pkg/clientsetthat have been deprecated since 3.4.0.Remove linters, Makefile, etc., related configs.
Document in
CHANGELOG.mdpath to move forward for someone who may still use it.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR