Skip to content

Commit 3a10e16

Browse files
Merge branch 'bug-3897_master' of https://github.com/mmoqui/Silverpeas-Core into mmo-bug3849
2 parents e608b4f + a6a07da commit 3a10e16

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

war-core/src/main/webapp/selection/jsp/userpanel.jsp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -615,9 +615,16 @@
615615
616616
// cancel the selection and go back to the caller.
617617
function cancelSelection() {
618+
<c:choose>
619+
<c:when test="${hotSetting}">
620+
window.close();
621+
</c:when>
622+
<c:otherwise>
618623
$('input[name="UserOrGroupSelection"]').val('false');
619624
$("#selection").attr("action", "<c:out value='${cancelationURL}'/>");
620625
$("#selection").submit();
626+
</c:otherwise>
627+
</c:choose>
621628
}
622629
623630
function highlightFilter($this) {

web-core/src/test/java/com/silverpeas/profile/web/UserProfileTestResources.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -157,15 +157,15 @@ public UserDetail[] answer(InvocationOnMock invocation) throws Throwable {
157157
&& !passedCriteria.isCriterionOnNameSet())) {
158158
return emptyUsers;
159159
}
160-
if (criteria.isCriterionOnRoleIdsSet() && passedCriteria.isCriterionOnRoleIdsSet()) {
161-
List<String> roles = Arrays.asList(criteria.getCriterionOnRoleIds());
162-
List<String> passedRoles = Arrays.asList(passedCriteria.getCriterionOnRoleIds());
160+
if (criteria.isCriterionOnRoleNamesSet() && passedCriteria.isCriterionOnRoleNamesSet()) {
161+
List<String> roles = Arrays.asList(criteria.getCriterionOnRoleNames());
162+
List<String> passedRoles = Arrays.asList(passedCriteria.getCriterionOnRoleNames());
163163
if (roles.size() != passedRoles.size() || !roles.containsAll(passedRoles)) {
164164
return emptyUsers;
165165
}
166-
} else if ((!criteria.isCriterionOnRoleIdsSet()
167-
&& passedCriteria.isCriterionOnRoleIdsSet()) || (criteria.isCriterionOnRoleIdsSet()
168-
&& !passedCriteria.isCriterionOnRoleIdsSet())) {
166+
} else if ((!criteria.isCriterionOnRoleNamesSet()
167+
&& passedCriteria.isCriterionOnRoleNamesSet()) || (criteria.isCriterionOnRoleNamesSet()
168+
&& !passedCriteria.isCriterionOnRoleNamesSet())) {
169169
return emptyUsers;
170170
}
171171
if (criteria.isCriterionOnUserIdsSet() && passedCriteria.isCriterionOnUserIdsSet()) {

0 commit comments

Comments
 (0)