Feature #13861

Take into account the refinement of the array pane items.
Take into account renaming of a method in Administration.
Take into account the new field in ST_User table: sensitiveData.
Take into account email addresses of users for which privacy has been
enabled aren't provided: find a way to get them for emailing them the
newsletters.
Ensure in WhitePages the sensitive information in user cards aren't
disclosed. Take into account the indexation of such cards by removing
any sensitive data for users for which privacy has been enabled.

Author: mmoqui

blog/blog-war/src/main/webapp/blog/jsp/viewCategory.jsp

@@ -185,8 +185,7 @@ function sortNode(updatedNodeJSON)
 <%  
 	ArrayPane arrayPane = gef.getArrayPane("categoryList", "ViewCategory", request, session);
 	arrayPane.setSortable(false);
-	arrayPane.setXHTML(true);
-	arrayPane.setSortableLines(true);
+	arrayPane.setMovableLines(true);
 	arrayPane.addArrayColumn("&nbsp;");
 	arrayPane.addArrayColumn(resource.getString("GML.title"));
 	arrayPane.addArrayColumn(resource.getString("GML.description"));

community/community-library/src/integration-test/resources/community-database.sql

@@ -32,6 +32,7 @@ CREATE TABLE IF NOT EXISTS ST_User
     state                         VARCHAR(30)         NOT NULL,
     stateSaveDate                 TIMESTAMP           NOT NULL,
     notifManualReceiverLimit      INT,
+    sensitiveData                 BOOLEAN DEFAULT FALSE NOT NULL,
     CONSTRAINT PK_User PRIMARY KEY (id),
     CONSTRAINT UN_User_1 UNIQUE (specificId, domainId),
     CONSTRAINT UN_User_2 UNIQUE (login, domainId),

community/community-war/src/main/webapp/community/jsp/history.jsp

@@ -72,7 +72,11 @@
     <view:window>
       <view:frame>
         <div id="history-list">
-          <view:arrayPane title="${historyListLabel}" var="communityHistoryViewIdentifier" routingAddress="${componentUriBase}/members/history" export="true" numberLinesPerPage="25">
+          <view:arrayPane title="${historyListLabel}"
+                          var="communityHistoryViewIdentifier"
+                          routingAddress="${componentUriBase}/members/history"
+                          numberLinesPerPage="25"
+                          export="true">
             <view:arrayColumn title="${lastNameLabel}" compareOn="${r -> fn:toLowerCase(r.user.lastName)}"/>
             <view:arrayColumn title="${firstNameLabel}" compareOn="${r -> fn:toLowerCase(r.user.firstName)}"/>
             <view:arrayColumn title="${statusLabel}" compareOn="${r -> fn:toLowerCase(r.getStatusLabel(currentUserLanguage))}"/>

community/community-war/src/main/webapp/community/jsp/members.jsp

@@ -74,7 +74,11 @@
     <view:window>
       <view:frame>
         <div id="members-list">
-          <view:arrayPane title="${memberListLabel}" var="communityMemberListIdentifier" routingAddress="${componentUriBase}/members" export="true" numberLinesPerPage="25">
+          <view:arrayPane title="${memberListLabel}"
+                          var="communityMemberListIdentifier"
+                          routingAddress="${componentUriBase}/members"
+                          numberLinesPerPage="25"
+                          export="true">
             <view:arrayColumn title="${lastNameLabel}" compareOn="${r -> fn:toLowerCase(r.user.lastName)}"/>
             <view:arrayColumn title="${firstNameLabel}" compareOn="${r -> fn:toLowerCase(r.user.firstName)}"/>
             <c:if test="${adminMustValidateNewMember}">

delegatednews/delegatednews-library/src/integration-test/resources/org/silverpeas/components/delegatednews/dao/create-database.sql

@@ -46,6 +46,7 @@
         state                         VARCHAR(30)          NOT NULL,
         stateSaveDate                 TIMESTAMP            NOT NULL,
         notifManualReceiverLimit      INT,
+        sensitiveData                 BOOLEAN DEFAULT FALSE NOT NULL,
         CONSTRAINT PK_User PRIMARY KEY (id),
         CONSTRAINT UN_User_1 UNIQUE(specificId, domainId),
         CONSTRAINT UN_User_2 UNIQUE(login, domainId),

delegatednews/delegatednews-library/src/integration-test/resources/org/silverpeas/components/delegatednews/service/create-database.sql

@@ -30,6 +30,7 @@ CREATE TABLE IF NOT EXISTS ST_User
     state                         VARCHAR(30)          NOT NULL,
     stateSaveDate                 TIMESTAMP            NOT NULL,
     notifManualReceiverLimit      INT,
+    sensitiveData                 BOOLEAN DEFAULT FALSE NOT NULL,
     CONSTRAINT PK_User PRIMARY KEY (id),
     CONSTRAINT UN_User_1 UNIQUE(specificId, domainId),
     CONSTRAINT UN_User_2 UNIQUE(login, domainId),

delegatednews/delegatednews-war/src/main/webapp/delegatednews/jsp/listNews.jsp

@@ -287,7 +287,7 @@
   <%
     ArrayPane arrayPane = gef.getArrayPane("newsList", "Main", request, session);
     arrayPane.setVisibleLineNumber(1000);
-    arrayPane.setSortableLines(true);
+    arrayPane.setMovableLines(true);
     arrayPane.setTitle(resources.getString("delegatednews.listNews"));
     arrayPane.addArrayColumn(resources.getString("delegatednews.news.title"));
     ArrayColumn column = arrayPane.addArrayColumn(resources.getString("delegatednews.updateDate"));

formsOnline/formsOnline-library/src/integration-test/resources/org/silverpeas/components/formsonline/model/create-database.sql

@@ -109,5 +109,6 @@ CREATE TABLE ST_User
     expirationDate                TIMESTAMP,
     state                         VARCHAR(30)         NOT NULL,
     stateSaveDate                 TIMESTAMP           NOT NULL,
-    notifManualReceiverLimit      INT
+    notifManualReceiverLimit      INT,
+    sensitiveData                 BOOLEAN DEFAULT FALSE NOT NULL
 );

formsOnline/formsOnline-war/src/main/java/org/silverpeas/components/formsonline/control/TitleHelper.java

@@ -252,24 +252,24 @@ public void updateInfoLetterPublication(InfoLetterPublicationPdC ilp) {
 
   @Override
   public InfoLetter getInfoLetter(WAPrimaryKey letterPK) {
-    InfoLetter retour;
+    InfoLetter infoLetter;
     try {
-      retour = infoLetterDAO.findByPrimaryKey(letterPK);
+      infoLetter = infoLetterDAO.findByPrimaryKey(letterPK);
     } catch (PersistenceException pe) {
       throw new InfoLetterException(pe);
     }
-    return retour;
+    return infoLetter;
   }
 
   @Override
   public InfoLetterPublicationPdC getInfoLetterPublication(WAPrimaryKey publiPK) {
-    InfoLetterPublicationPdC retour;
+    InfoLetterPublicationPdC classifiedPublic;
     try {
-      retour = new InfoLetterPublicationPdC(infoLetterPublicationDAO.findByPrimaryKey(publiPK));
+      classifiedPublic = new InfoLetterPublicationPdC(infoLetterPublicationDAO.findByPrimaryKey(publiPK));
     } catch (PersistenceException pe) {
       throw new InfoLetterException(pe);
     }
-    return retour;
+    return classifiedPublic;
   }
 
   @Override
@@ -358,7 +358,7 @@ public void setInternalSuscribers(final String componentId, final UserDetail[] u
 
   @Override
   public Set<String> getEmailsExternalsSuscribers(WAPrimaryKey letterPK) {
-    Set<String> retour = new LinkedHashSet<>();
+    Set<String> emails = new LinkedHashSet<>();
     try (Connection con = openConnection()) {
       InfoLetter letter = getInfoLetter(letterPK);
       String selectQuery =
@@ -369,14 +369,14 @@ public Set<String> getEmailsExternalsSuscribers(WAPrimaryKey letterPK) {
         //noinspection SqlSourceToSinkFlow
         try (ResultSet rs = selectStmt.executeQuery(selectQuery)) {
           while (rs.next()) {
-            retour.add(rs.getString("email"));
+            emails.add(rs.getString("email"));
           }
         }
       }
     } catch (Exception e) {
       throw new InfoLetterException(e);
     }
-    return retour;
+    return emails;
   }
 
   @Transactional

infoLetter/infoLetter-library/src/main/java/org/silverpeas/components/infoletter/implementation/InfoLetterDataManager.java

@@ -40,10 +40,6 @@ public class InfoLetterPublicationPdC extends InfoLetterPublication
     implements SilverContentInterface {
   private static final long serialVersionUID = -2174573301215680444L;
   public static final String TYPE = "publication";
-  /**
-   * icone d'une publication
-   */
-  private String iconUrl = "infoLetterSmall.gif";
 
   private String silverObjectId;
   private String positions;
@@ -105,7 +101,10 @@ public String getCreatorId() {
 
   @Override
   public String getIconUrl() {
-    return iconUrl;
+    /*
+     * publication icon
+     */
+    return "infoLetterSmall.gif";
   }
 
   @Override