Skip to content

Commit e5aa610

Browse files
committed
fixing a hidden technical error discovered when accessing public kmelia instance with anonymous session.
1 parent 7a4b2fb commit e5aa610

File tree

1 file changed

+6
-1
lines changed
  • kmelia/kmelia-war/src/main/java/org/silverpeas/components/kmelia/servlets

1 file changed

+6
-1
lines changed

kmelia/kmelia-war/src/main/java/org/silverpeas/components/kmelia/servlets/JSONServlet.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@
3939
import javax.servlet.http.HttpServletResponse;
4040
import java.io.IOException;
4141
import java.io.Writer;
42+
import java.util.Collection;
4243

44+
import static java.util.Optional.ofNullable;
45+
import static java.util.function.Predicate.not;
4346
import static org.silverpeas.core.web.selection.BasketSelectionUI.displayPutIntoBasketSelectionShortcut;
4447

4548
public class JSONServlet extends HttpServlet {
@@ -128,7 +131,9 @@ private void addPublicationOperations(final KmeliaSessionController kmeliaSC,
128131
boolean addPublicationAllowed = !role.isUser() && publicationsInTopic;
129132
boolean operationsOnSelectionAllowed =
130133
(role.isAdmin() || role.isPublisher()) && publicationsInTopic;
131-
boolean somePublicationsExist = !kmeliaSC.getSessionPublicationsList().isEmpty();
134+
boolean somePublicationsExist = ofNullable(kmeliaSC.getSessionPublicationsList())
135+
.filter(not(Collection::isEmpty))
136+
.isPresent();
132137
boolean oneTemplateUsed = kmeliaSC.getXmlFormForPublications() != null;
133138
boolean copyCutAllowed = operationsOnSelectionAllowed && somePublicationsExist;
134139
boolean notRootNotAnonymous = !isRoot && !user.isAnonymous();

0 commit comments

Comments
 (0)