As with KmeliaService#sendPublicationInBasket, the method

KmeliaService#deletePublication is now private to the implementor.
Add a new method in KmeliaService:
deletePublication(PublicationPK pubPK, String userId). This business
method is dedicated to be used by SendInKmelia workflow action handlers
to remove a publication that was published by a workflow in a Kmelia
instance. But this method can be also used by others business services.
The method now checks the user for which the deletion is invoked has the
right to perform the action. Then, if the publication is already in the
trash, it is definitively deleted, otherwise it is moved into the trash.
By doing so, this business behaviour is well encapsulated by
KmeliaService and doesn't require to spill it over others business
services.

Author: mmoqui

kmelia/kmelia-library/src/main/java/org/silverpeas/components/kmelia/service/DefaultKmeliaService.java

@@ -1377,11 +1377,12 @@ private boolean isClone(PublicationDetail publication) {
         !isDefined(publication.getCloneStatus());
   }
 
-  @Override
-  @Transactional(Transactional.TxType.REQUIRED)
-  public void deletePublication(PublicationPK pubPK) {
-    // if the publication is in the basket or in the DZ
-    // this publication is deleted from the database
+  /**
+   * Deletes definitively the specified publication.
+   *
+   * @param pubPK the unique identifier of the publication to delete.
+   */
+  private void deletePublication(PublicationPK pubPK) {
     KmeliaOperationContext.about(DELETION);
     try {
       // remove form content
@@ -3921,6 +3922,26 @@ public List<String> deletePublications(List<String> publiIds, NodePK topicId, St
     return removedIds;
   }
 
+  @Override
+  @Transactional(Transactional.TxType.REQUIRED)
+  public void deletePublication(PublicationPK pubPK, String userId) {
+    NodePK topicId = publicationService.getMainLocation(pubPK)
+        .orElse(null);
+    String profile = topicId != null ? getProfile(userId, topicId) : null;
+    if (profile != null && isUserCanDeletePublication(pubPK, profile, userId)) {
+      try {
+        if (topicId.isTrash()) {
+          deletePublication(pubPK);
+        } else {
+          sendPublicationInBasket(pubPK);
+        }
+      } catch (Exception e) {
+        SilverLogger.getLogger(this)
+            .error("Deletion of publication {0} failed", new String[]{pubPK.getId()}, e);
+      }
+    }
+  }
+
   @Transactional(Transactional.TxType.REQUIRED)
   @Override
   public void deleteTopic(@NonNull NodePK topic, String userId) {

kmelia/kmelia-library/src/main/java/org/silverpeas/components/kmelia/service/KmeliaService.java

@@ -249,13 +249,6 @@ String createPublicationIntoTopic(PublicationDetail pubDetail, NodePK fatherPK,
 
   void updatePublication(PublicationDetail detail, boolean forceUpdateDate);
 
-  /**
-   * Deletes definitively the specified publication.
-   *
-   * @param pubPK the unique identifier of the publication to delete.
-   */
-  void deletePublication(PublicationPK pubPK);
-
   /**
    * Add a publication to a topic and send email alerts to topic subscribers
    *
@@ -739,20 +732,33 @@ String clonePublication(CompletePublication refPubComplete, PublicationDetail pu
 
   /**
    * Deletes the specified publications located into the given topic. Before a publication is
-   * removed, the privileges of the specified user is checked. If the topic is the trash folder,
-   * then the publications are definitively deleted. Otherwise, they are just moved into the bin.
+   * removed, the privileges of the specified user is checked. This user can be the requester or
+   * another user endorsing the deletion for the requester. If the topic is the trash folder, then
+   * the publications are definitively deleted. Otherwise, they are just moved into the bin.
    *
    * @param publiIds a list of local identifier of the publications to delete.
    * @param topicId the node PK of the topic in which the publications are located.
-   * @param userId the unique identifier of the user asking the deletion.
+   * @param userId the unique identifier of the user for which the deletion is performed.
    * @return the list of the unique identifiers of the actually deleted publications.
    */
   List<String> deletePublications(List<String> publiIds, NodePK topicId, String userId);
 
+  /**
+   * Deletes the specified publication. Before the publication is removed, the privileges of the
+   * given user is checked. This user can be the requester or another user endorsing the deletion
+   * for the requester. For doing, the profile of the user is checked against the topic in which the
+   * publication is originally located. If the topic is the trash folder, then the publication is
+   * definitively deleted. Otherwise, it is just moved into the bin.
+   *
+   * @param pubPK the unique identifier of the publication.
+   * @param userId the unique identifier of the user for which the deletion is performed.
+   */
+  void deletePublication(PublicationPK pubPK, String userId);
+
   /**
    * Deletes the specified topic located into the given parent topic. Before the topic is deleted,
-   * the privileges of the specified user is checked. If topic is in the trash folder, then
-   * the topic is definitively deleted. Otherwise it is just moved into the bin.
+   * the privileges of the specified user is checked. If topic is in the trash folder, then the
+   * topic is definitively deleted. Otherwise it is just moved into the bin.
    *
    * @param topic the unique identifier of the topic
    * @param userId the unique identifier of the user asking the deletion.