Feature 13497: it is now possible in a workflow to replace an incumbent in a REMOVED state by a substitute.

Author: SilverYoCha

processManager/processManager-war/src/main/java/org/silverpeas/processmanager/ProcessManagerSessionController.java

@@ -607,11 +607,10 @@ private List<String> getUsers(QualifiedUsers qualifiedUsers, boolean useCurrentR
         roles.clear();
       }
     }
-
-    String[] userIds = getOrganisationController().getUsersIdsByRoleNames(getComponentId(), roles);
-    for (final String userId : userIds) {
-      users.add(userId);
-    }
+    final boolean lookAlsoForRemoved = getCurrentReplacement() != null;
+    final String[] userIds = getOrganisationController().getUsersIdsByRoleNames(getComponentId(),
+        roles, lookAlsoForRemoved);
+    users.addAll(Arrays.asList(userIds));
 
     // Process related groups
     RelatedGroup[] relatedGroups = qualifiedUsers.getRelatedGroups();

processManager/processManager-war/src/main/webapp/processManager/jsp/javaScript/vuejs/replacement-templates.jsp

@@ -240,6 +240,7 @@
             v-on:api="selectIncumbentApi = $event"
             v-on:selection-change="incumbentChanged($event.selectedUserIds)"
             v-bind:initial-user-ids="replacement.incumbent && replacement.incumbent.id"
+            v-bind:include-removed-users="true"
             v-bind:read-only="!(context.currentUser.isSupervisor && isCreation)"
             v-bind:role-filter="incumbentRoleFilter"
             v-bind:component-id-filter="context.componentInstanceId"></silverpeas-user-group-select>
@@ -263,6 +264,7 @@
             v-on:api="selectSubstituteApi = $event"
             v-on:selection-change="substituteChanged($event.selectedUserIds)"
             v-bind:initial-user-ids="replacement.substitute && replacement.substitute.id"
+            v-bind:include-removed-users="true"
             v-bind:role-filter="selectedSubstituteFilterRoles"
             v-bind:component-id-filter="context.componentInstanceId"></silverpeas-user-group-select>
       </div>

processManager/processManager-war/src/main/webapp/processManager/jsp/javaScript/vuejs/replacement.service.js

@@ -47,6 +47,7 @@
       return User.get({
         component : context.componentInstanceId,
         userStatesToExclude : ['DEACTIVATED'],
+        includeRemoved : true,
         roles : roleName
       }).then(function(users) {
         users.forEach(function(user) {