Bug #14732

The regression was introduced with the fix of the bug #14661.
Ensure now the access to a given publication is done correctly by
clicking on its name wrapped by a span tag with at least the class
'pub-link' (a shortcut/alias cannot be d&d like a normal publication).

In the seeAlso.tag, encode for HTML both the description and the title
of a referenced publication.

Author: mmoqui

kmelia/kmelia-war/src/main/java/org/silverpeas/components/kmelia/servlets/renderers/PublicationsRenderer.java

@@ -561,7 +561,8 @@ void renderPublicationDefaultFragment(KmeliaPublication aPub,
         "    a.addEventListener('click', function(e) {\n" +
         "      e.preventDefault();\n" +
         "      e.stopPropagation();\n" +
-        "      const pubId = this.querySelector('span.jstree-draggable').getAttribute('id').trim().slice(4);\n" +
+        "      const pubId = this.querySelector('span.pub-link').getAttribute('id').trim().slice" +
+        "(4);\n" +
         "      publicationGoTo(pubId);\n" +
         "    });" +
         "  });" +
@@ -664,14 +665,19 @@ private static void renderPublicationRef(PublicationDetail pub, String name, Wri
 
   private static void renderPublicationLink(PublicationDetail pub, String name, Writer writer,
       PublicationFragmentSettings fragmentSettings) throws IOException {
-    writer.write("<div class=\"");
-    writer.write(fragmentSettings.getPubColor());
-    writer.write("\"><a href=\"#\"><span class=\"" + fragmentSettings.getHighlightClass() + "\">");
+    if (StringUtil.isDefined(fragmentSettings.getPubColor())) {
+      writer.write("<div class=\"");
+      writer.write(fragmentSettings.getPubColor());
+      writer.write("\"><a href=\"#\">");
+    } else {
+      writer.write("<div><a href=\"#\">");
+    }
+    writer.write("<span id=\"pub-" + pub.getPK().getId() + "\" class=\"pub-link");
     if (fragmentSettings.isDraggable()) {
-      writer.write("<span class=\"jstree-draggable\" id=\"pub-" + pub.getPK().getId() + "\">");
+      writer.write(" jstree-draggable\">");
       writer.write(name);
-      writer.write(END_SPAN);
     } else {
+      writer.write("\">");
       writer.write(name);
     }
     writer.write("</span></a></div>");

kmelia/kmelia-war/src/main/webapp/WEB-INF/tags/silverpeas/kmelia/seeAlso.tag

@@ -65,7 +65,12 @@
             <c:set var="seeAlsoClassName" value="seeAlsoReverse"/>
           </c:if>
           <li id="link-${seeAlso.id}" class="showActionsOnMouseOver ${seeAlsoClassName}">
-            <a href="${seeAlso.pub.permalink}" class="sp-permalink" title="${seeAlso.pub.description}">${seeAlso.pub.name} <span>- <view:formatDate value="${seeAlso.pub.lastUpdateDate}"/></span></a>
+            <a href="${seeAlso.pub.permalink}" class="sp-permalink"
+               title="${silfn:escapeHtmlWhitespaces(seeAlso.pub.description)}">
+                ${silfn:escapeHtml(seeAlso.pub.name)}
+              <span>-
+              <view:formatDate
+                    value="${seeAlso.pub.lastUpdateDate}"/></span></a>
             <c:if test="${not readOnly && not seeAlso.reverse}">
               <div class="actionShownOnMouseOver"><a class="delete" href="#" onclick="deleteLink('${seeAlso.id}');return false;" title="${labelDelete}">${labelDelete}</a></div>
             </c:if>
@@ -76,7 +81,8 @@
 
     <script type="text/javascript">
       function deleteLink(id) {
-        var ajaxRequest = sp.ajaxRequest(webContext+"/services/private/publications/${publicationPK.instanceId}/${publicationPK.id}/links/"+id).byDeleteMethod();
+        let ajaxRequest =
+                sp.ajaxRequest(webContext+"/services/private/publications/${publicationPK.instanceId}/${publicationPK.id}/links/"+id).byDeleteMethod();
         ajaxRequest.send().then(function() {
           $("#link-"+id).remove();
           if ($("#block-seeAlso ul li").size() === 0) {