Feature 9990 #614
Feature 9990 #614
Conversation
mmoqui
force-pushed
the
feature-9990
branch
2 times, most recently
from
b7cb2c3 to
a5fb86a
Compare
|
Here are my feedbacks :
|
|
My answers to some of your questions:
Yes, because by default, the value of such fields are
What do you mean by "not empty" control? Gives me the steps of the test in which such a control should be invoked.
No, I don't think so. It is the behavior in JDBCConnector and then I think it should be also the behavior of MyDB in Silverpeas 5: only the users having a role authorizing a modification have the right to select the default table for the current data source. |
mmoqui
force-pushed
the
feature-9990
branch
2 times, most recently
from
f765564 to
d5720d1
Compare
|
For information, I've updated the code to take into account your different remarks. |
mmoqui
force-pushed
the
feature-9990
branch
from
d5720d1 to
94db7c3
Compare
Improve a little some of the JDBC Connector application code. Restore the MyDB application and rewrite its code from the JDBC Connector's one: this first step is about only to read the content of a given table as well as to apply some filter on its content (like it is does in JDBC Connector).
- The filtering on the current table rows is now performed directly in the SQL query. This implies that each time a table is viewed, the request is executed. - When fetching the columns of a table, both their name and their SQL type are get. - Use of JdbcSqlQuery in the requesting of the database.
For doing, we don't use anymore the programmatic build of an XML form in order to both render the row modification form and to take into account the SQL types in the rendering of the HTML inputs by converting them to the predefined types of the XML form fields. Instead we use a classic HTML form directly built from the row to be updated and by taking into account some of the SQL types of each row's field. The form is rendered directly within a javascript popin, providing a better user experience (read modern user experience). Because the publishers can update the content of a database table's row, because the publishers work directly with a database, the characteristics and the constrains of SQL is no more (and badly) hidden by the GUI. It is expected the publishers know SQL to update the rows of a table; we provide only a GUI-way to do that (not a simple SQL statement editor).
Fix some bugs. Improve the feedback when an error is encountered while requesting the database. Add the insertion of a new row into the default table.
…olumns are foreign keys to a row of another table and improve the user experience by opening the targeted table to allow the user to select the row that will be referred by the foreign key in the current edited row of the default table (id est table that is currently selected for the current selected data source.)
described here: pgjdbc/pgjdbc#892 https://www.cis.upenn.edu/~bcpierce/courses/629/jdkdocs/guide/jdbc/getstart/mapping.doc.html Fix a bug with the setting of the selected foreign key in the edition form of a row (the bug is fixed by deleting any the HTML root element of the popup when closed).
Don't forget to merge PR:
Silverpeas/Silverpeas-Assembly#16
Silverpeas/Silverpeas-Core#930