bug #13969: news displaying now use the pagination at first access #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mmoqui
reviewed
Nov 20, 2024
| @@ -286,7 +286,7 @@ | |||
| <form name="tabForm" method="post"> | |||
| <% | |||
| ArrayPane arrayPane = gef.getArrayPane("newsList", "Main", request, session); | |||
| arrayPane.setVisibleLineNumber(1000); | |||
| arrayPane.setVisibleLineNumber(GraphicElementFactory.getSettings().getInteger("Pagination.NumberPerPageThreshold",20)); | |||
There was a problem hiding this comment.
Why don't use the occasion to replace the Java code of ArrayPane by its counterpart view:arrayPane?
There was a problem hiding this comment.
I updated the ArrayPaneTag code so that the visible line number is initialized by default with the Pagination.NumberPerPageThreshold property. So setting explicitly the visible line number isn't anymore required for array pane.
There was a problem hiding this comment.
ok, i'm working on the replacement of the servlet code by jstl..
mmoqui
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.