Improve the XSS fix in user notification and web messages #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parameters on the message instead of using the LocalizationBundle#getStringWithParams for that. When building a user notification about the modification or the creation of a contribution in the different Silverpeas apps, encode for HTML the title/name and the description of the contribution.
mmoqui
force-pushed
the
feature-xssFix
branch
from
825f52d to
9de21a4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Web messager, prefer to use its capability to apply parameters on the message instead of using the
LocalizationBundle#getStringWithParams for that.
Related to PR Silverpeas/Silverpeas-Core#1376