Bug #14661 #888
Merged
Bug #14661 #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the bug. The d&d handling was based upon the .jstree-draggable class. But since the refactoring within the fix of the bug 14478, the <span> with this CSS class didn't receive anymore the mouse event but its <a> parent because this one had a class attribute set. Without the class attribute in the <a> parent, the <span> element succeed to receive any mouse click down event on it. Nevertheless, in order the d&d mechanism works on publications, it was needed to move the id attribute from the <a> element to the <span class=".jstree-draggable> element because this publication identifier is fetched from this id on the dragged HTML node. So, the click event handler of the <a> node required to be refined to take into account of this (because the id attribute was also fetched to figure out the identifier of the publication to redirect the user to.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug. The d&d handling was based upon the .jstree-draggable class. But since the refactoring within the fix of the bug 14478, the with this CSS class didn't receive anymore the mouse event but its parent because this one had a class attribute set. Without the class attribute in the parent, the element succeed to receive any mouse click down event on it. Nevertheless, in order the d&d mechanism works on publications, it was needed to move the id attribute from the element to the <span class=".jstree-draggable> element because this publication identifier is fetched from this id on the dragged HTML node. So, the click event handler of the node required to be refined to take into account of this (because the id attribute was also fetched to figure out the identifier of the publication to redirect the user to.