bug #14769 : The start hour and the end Hour are now well processed

[SilverDav]

No description provided.

[mmoqui]

The current code is problematic because LocalDateTime is used. LocalDateTime is built from the timezone of the server. But the date time that is passed by the form is in the timezone of the user who filled the form. The two timezones can be the same (the one of the server and the one of the user) but such assumptions should be avoided and the timezone of the user has to be taken. Snippet of code to get the correct zone id:

User requester = User.getCurrentRequester();
ZoneId zoneId;
if (requester != null) {
  zoneId = requester.getUserPreferences().getZoneId();
} else {
  zoneId = ZoneId.systemDefault();
}
...
if (StringUtil.isValidHour(startHourValue)) {
  var localDateTime = LocalDateTime.parse(startDayValue + " " + startHourValue, DATE_TIME_FORMATTER);
  var offset = ZoneId.systemDefault().getRules().getOffset(localDateTime.atZone(zoneId).toInstant());
  start = localDateTime.atOffset(offset);
}
...

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud