feature #14846 : Avatar filename can be in lowercase if login is in u… #1402
Conversation
…ppercase (and vice-versa)
|
| if (ignoreCaseForPropertyValue) { | ||
| avatar = avatar.exists()?avatar:new File(FileRepositoryManager.getAvatarPath(), fileName.toUpperCase()); | ||
| } | ||
| return avatar; |
There was a problem hiding this comment.
Pb here: it doesn't work if the login is in uppercase and the avatar filename is in lowercase. If the character case has to be ignored, then all the possibility has to be taken into account when accessing the avatar file. This isn't possible without having a complex and stupid code.
The better way is to fix the convention on the avatar filename as to be the one of the login (which cannot be modified) and then ensure the avatar upload satisfies this rule. It shouldn't a diff between the avatar filename and the login.
|
This PR is closed because the issue comes from the operator who uploads a set of avatars. He didn't care about the case of the filenames in his Windows machine. (The name of the avatar files must be in lowercase.) The code doesn't have to be complicated for just such a stuff. |
…ppercase (and vice-versa)