From 4670920c2b0a9cd11b25b71bfea7b39cf9b2e025 Mon Sep 17 00:00:00 2001
From: Miguel Moquillon <miguel.moquillon@silverpeas.com>
Date: Tue, 6 May 2025 10:17:06 +0200
Subject: [PATCH] Bug #14770

Whatever a rich content of a contribution is added or updated, check
the content cache for text to decide if a notification about
contribution modification has to be triggered (in the case such notif
is supported).
---
 .../main/webapp/wysiwyg/jsp/htmlEditor.jsp    | 67 ++++++++++---------
 1 file changed, 34 insertions(+), 33 deletions(-)

diff --git a/core-war/src/main/webapp/wysiwyg/jsp/htmlEditor.jsp b/core-war/src/main/webapp/wysiwyg/jsp/htmlEditor.jsp
index 61abbfd019..59c47d7123 100644
--- a/core-war/src/main/webapp/wysiwyg/jsp/htmlEditor.jsp
+++ b/core-war/src/main/webapp/wysiwyg/jsp/htmlEditor.jsp
@@ -286,7 +286,7 @@
 
 <script type="text/javascript">
 
-  var $deferred;
+  let $deferred;
 
   <c:if test="${not empty param.notySuccess}">
   $(document).ready(function(){
@@ -300,7 +300,7 @@
       browseInfo="<%=browseInformation%>" objectId="<%=objectId%>" objectType="<%=objectType%>"
       activateWysiwygBackupManager="true" />
 
-    if ($.trim($(".wysiwyg-fileStorage").text()).length == 0) {
+    if ($.trim($(".wysiwyg-fileStorage").text()).length === 0) {
       $(".wysiwyg-fileStorage").css("display", "none");
     }
   };
@@ -330,9 +330,9 @@
   }
 
   function choixLien() {
-    var index = document.recupHtml.liens.selectedIndex;
-    var str = document.recupHtml.liens.options[index].value;
-    if (index != 0 && str != null) {
+    const index = document.recupHtml.liens.selectedIndex;
+    const str = document.recupHtml.liens.options[index].value;
+    if (index !== 0 && str != null) {
       CKEDITOR.instances.editor1.insertHtml('<a href="' + str + '">' +
       str.substring(str.lastIndexOf("/") + 1) + "</a>");
     }
@@ -413,6 +413,11 @@
 
     jQuery(document).ready(function() {
       jQuery(document.recupHtml).submit(function() {
+        const wysiwygContent =
+                sp.editor.wysiwyg.lastBackupManager.instance.existsUnvalidatedContent() ?
+                        sp.editor.wysiwyg.lastBackupManager.instance.getUnvalidatedContent() : '';
+        const modifContextEnabled = ${isModificationContextEnabled};
+        const subscriptionHandled = ${isHandledSubscriptionConfirmation};
         const contributionId = {
           componentInstanceId : '<%=componentId%>',
           localId : '<%=objectId%>',
@@ -420,35 +425,31 @@
         };
         jQuery.contributionModificationContext.validateOnUpdate({
           contributionId : contributionId,
-          status : ${silfn:isDefined(wysiwygTextValue)  and isModificationContextEnabled
-           ? 'undefined'
-           : '$.contributionModificationContext.statuses.CREATION'},
+          status : wysiwygContent.length > 0 && modifContextEnabled ?
+                  undefined : '$.contributionModificationContext.statuses.CREATION',
           callback : function() {
-            <c:choose>
-            <c:when test="${silfn:isDefined(wysiwygTextValue) and isHandledSubscriptionConfirmation}">
-            jQuery.subscription.confirmNotificationSendingOnUpdate({
-              contribution : {
-                contributionId : contributionId,
-                indexable : <%=indexIt%>,
-                locationId : '${handledSubscriptionLocationId}'
-              },
-              comment : {
-                saveNote : ${silfn:booleanValue(commentActivated)}
-              },
-              subscription : {
-                componentInstanceId : '<%=componentId%>',
-                type : '${handledSubscriptionType}',
-                resourceId : '${handledSubscriptionResourceId}'
-              },
-              callback : function() {
-                commit.call(this, false);
-              }
-            });
-            </c:when>
-            <c:otherwise>
-            commit.call(this, ${silfn:isNotDefined(wysiwygTextValue) ? 'true' : 'false'});
-            </c:otherwise>
-            </c:choose>
+            if (wysiwygContent.length > 0 && subscriptionHandled) {
+              jQuery.subscription.confirmNotificationSendingOnUpdate({
+                contribution: {
+                  contributionId: contributionId,
+                  indexable: <%=indexIt%>,
+                  locationId: '${handledSubscriptionLocationId}'
+                },
+                comment: {
+                  saveNote: ${silfn:booleanValue(commentActivated)}
+                },
+                subscription: {
+                  componentInstanceId: '<%=componentId%>',
+                  type: '${handledSubscriptionType}',
+                  resourceId: '${handledSubscriptionResourceId}'
+                },
+                callback: function () {
+                  commit.call(this, false);
+                }
+              });
+            } else {
+              commit.call(this, wysiwygContent.length === 0);
+            }
         }});
         return false;
       });