Skip to content

Commit 0d5a389

Browse files
auroreallibemmoqui
authored andcommitted
Responding to @mmoqui requested changes on the previous PR
Responding to @mmoqui requested changes on the previous PR In the XML resources, missing de translation of some values. I commented out in data.xml, but the missing is also in the others XMLs. Just one point was ignored because you ask to change the key (not a label) define by default (carousel) . There is a notion of lang but I don't understand why, because it is just to defined the key used by default This part : > @@ -167,6 +239,14 @@ <name>values</name> <value lang="fr">Liste##Carrousel</value> </parameter> + <parameter> + <name>values</name> + <value lang="en">List##Carrousel</value> + </parameter> + <parameter> + <name>values</name> + <value lang="de">List##Carrousel</value> + </parameter> <parameter> <name>default</name> <value lang="fr">carousel</value>
1 parent 846addc commit 0d5a389

File tree

4 files changed

+258
-22
lines changed

4 files changed

+258
-22
lines changed

aurora/aurora-configuration/src/main/config/data/templateRepository/auroraspacehomepage/data.xml

Lines changed: 61 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,10 @@
7575
<name>values</name>
7676
<value lang="en">Yes##No</value>
7777
</parameter>
78+
<parameter>
79+
<name>values</name>
80+
<value lang="de">Ja##Nein</value>
81+
</parameter>
7882
<isSearchable>false</isSearchable>
7983
<isFacet>false</isFacet>
8084
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -115,6 +119,10 @@
115119
<name>values</name>
116120
<value lang="en">Yes##No</value>
117121
</parameter>
122+
<parameter>
123+
<name>values</name>
124+
<value lang="de">Ja##Nein</value>
125+
</parameter>
118126
<isSearchable>false</isSearchable>
119127
<isFacet>false</isFacet>
120128
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -151,6 +159,10 @@
151159
<name>values</name>
152160
<value lang="en">Yes##No</value>
153161
</parameter>
162+
<parameter>
163+
<name>values</name>
164+
<value lang="de">Ja##Nein</value>
165+
</parameter>
154166
<parameter>
155167
<name>cols</name>
156168
<value lang="fr">2</value>
@@ -241,11 +253,11 @@
241253
</parameter>
242254
<parameter>
243255
<name>values</name>
244-
<value lang="en">List##Carrousel</value>
256+
<value lang="en">List##Carousel</value>
245257
</parameter>
246258
<parameter>
247259
<name>values</name>
248-
<value lang="de">List##Carrousel</value>
260+
<value lang="de">Liste##Karussell</value>
249261
</parameter>
250262
<parameter>
251263
<name>default</name>
@@ -268,11 +280,11 @@
268280
<language>fr</language>
269281
</label>
270282
<label>
271-
<labelName>How many news ?</labelName>
283+
<labelName>Number of news</labelName>
272284
<language>en</language>
273285
</label>
274286
<label>
275-
<labelName>How many news ?</labelName>
287+
<labelName>Anzahl der Nachrichten</labelName>
276288
<language>de</language>
277289
</label>
278290
<parameter>
@@ -323,6 +335,10 @@
323335
<name>values</name>
324336
<value lang="en">Yes##No</value>
325337
</parameter>
338+
<parameter>
339+
<name>values</name>
340+
<value lang="de">Ja##Nein</value>
341+
</parameter>
326342
<parameter>
327343
<name>default</name>
328344
<value lang="fr">1</value>
@@ -367,6 +383,10 @@
367383
<name>values</name>
368384
<value lang="en">Yes##No</value>
369385
</parameter>
386+
<parameter>
387+
<name>values</name>
388+
<value lang="de">Ja##Nein</value>
389+
</parameter>
370390
<parameter>
371391
<name>default</name>
372392
<value lang="fr">0</value>
@@ -411,6 +431,10 @@
411431
<name>values</name>
412432
<value lang="en">Yes##No</value>
413433
</parameter>
434+
<parameter>
435+
<name>values</name>
436+
<value lang="de">Ja##Nein</value>
437+
</parameter>
414438
<isSearchable>false</isSearchable>
415439
<isFacet>false</isFacet>
416440
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -451,6 +475,10 @@
451475
<name>values</name>
452476
<value lang="en">Yes##No</value>
453477
</parameter>
478+
<parameter>
479+
<name>values</name>
480+
<value lang="de">Ja##Nein</value>
481+
</parameter>
454482
<isSearchable>false</isSearchable>
455483
<isFacet>false</isFacet>
456484
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -487,6 +515,10 @@
487515
<name>values</name>
488516
<value lang="en">Yes, about the entire platform##Yes, only on this subspace##No</value>
489517
</parameter>
518+
<parameter>
519+
<name>values</name>
520+
<value lang="de">Ja, über die gesamte Plattform##Ja, nur auf diesem Unterraum##Nein</value>
521+
</parameter>
490522
<isSearchable>false</isSearchable>
491523
<isFacet>false</isFacet>
492524
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -701,7 +733,7 @@
701733
</parameter>
702734
<parameter>
703735
<name>values</name>
704-
<value lang="de">Open in a new tab</value>
736+
<value lang="de">In einem neuen Tab öffnen</value>
705737
</parameter>
706738
<isSearchable>false</isSearchable>
707739
<isFacet>false</isFacet>
@@ -815,6 +847,10 @@
815847
<name>values</name>
816848
<value lang="en">Open in a new tab</value>
817849
</parameter>
850+
<parameter>
851+
<name>values</name>
852+
<value lang="de">In einem neuen Tab öffnen</value>
853+
</parameter>
818854
<isSearchable>false</isSearchable>
819855
<isFacet>false</isFacet>
820856
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -927,6 +963,10 @@
927963
<name>values</name>
928964
<value lang="en">Open in a new tab</value>
929965
</parameter>
966+
<parameter>
967+
<name>values</name>
968+
<value lang="de">In einem neuen Tab öffnen</value>
969+
</parameter>
930970
<isSearchable>false</isSearchable>
931971
<isFacet>false</isFacet>
932972
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -1039,6 +1079,10 @@
10391079
<name>values</name>
10401080
<value lang="en">Open in a new tab</value>
10411081
</parameter>
1082+
<parameter>
1083+
<name>values</name>
1084+
<value lang="de">In einem neuen Tab öffnen</value>
1085+
</parameter>
10421086
<isSearchable>false</isSearchable>
10431087
<isFacet>false</isFacet>
10441088
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -1151,6 +1195,10 @@
11511195
<name>values</name>
11521196
<value lang="en">Open in a new tab</value>
11531197
</parameter>
1198+
<parameter>
1199+
<name>values</name>
1200+
<value lang="de">In einem neuen Tab öffnen</value>
1201+
</parameter>
11541202
<isSearchable>false</isSearchable>
11551203
<isFacet>false</isFacet>
11561204
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -1263,6 +1311,10 @@
12631311
<name>values</name>
12641312
<value lang="en">Open in a new tab</value>
12651313
</parameter>
1314+
<parameter>
1315+
<name>values</name>
1316+
<value lang="de">In einem neuen Tab öffnen</value>
1317+
</parameter>
12661318
<isSearchable>false</isSearchable>
12671319
<isFacet>false</isFacet>
12681320
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -1407,6 +1459,10 @@
14071459
<name>values</name>
14081460
<value lang="en">Yes##No</value>
14091461
</parameter>
1462+
<parameter>
1463+
<name>values</name>
1464+
<value lang="de">Ja##Nein</value>
1465+
</parameter>
14101466
<isSearchable>false</isSearchable>
14111467
<isFacet>false</isFacet>
14121468
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>

aurora/aurora-configuration/src/main/config/data/templateRepository/auroraspacehomepage/searchresult.xml

Lines changed: 69 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@
3131
<name>values</name>
3232
<value lang="en">Yes##No</value>
3333
</parameter>
34+
<parameter>
35+
<name>values</name>
36+
<value lang="de">Ja##Nein</value>
37+
</parameter>
3438
<parameter>
3539
<name>cols</name>
3640
<value lang="fr">2</value>
@@ -75,6 +79,10 @@
7579
<name>values</name>
7680
<value lang="en">Yes##No</value>
7781
</parameter>
82+
<parameter>
83+
<name>values</name>
84+
<value lang="de">Ja##Nein</value>
85+
</parameter>
7886
<isSearchable>false</isSearchable>
7987
<isFacet>false</isFacet>
8088
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -115,6 +123,10 @@
115123
<name>values</name>
116124
<value lang="en">Yes##No</value>
117125
</parameter>
126+
<parameter>
127+
<name>values</name>
128+
<value lang="de">Ja##Nein</value>
129+
</parameter>
118130
<isSearchable>false</isSearchable>
119131
<isFacet>false</isFacet>
120132
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -151,6 +163,10 @@
151163
<name>values</name>
152164
<value lang="en">Yes##No</value>
153165
</parameter>
166+
<parameter>
167+
<name>values</name>
168+
<value lang="de">Ja##Nein</value>
169+
</parameter>
154170
<parameter>
155171
<name>cols</name>
156172
<value lang="fr">2</value>
@@ -241,11 +257,11 @@
241257
</parameter>
242258
<parameter>
243259
<name>values</name>
244-
<value lang="en">List##Carrousel</value>
260+
<value lang="en">List##Carousel</value>
245261
</parameter>
246262
<parameter>
247263
<name>values</name>
248-
<value lang="de">List##Carrousel</value>
264+
<value lang="de">Liste##Karussell</value>
249265
</parameter>
250266
<parameter>
251267
<name>default</name>
@@ -268,11 +284,11 @@
268284
<language>fr</language>
269285
</label>
270286
<label>
271-
<labelName>How many news ?</labelName>
287+
<labelName>Number of news</labelName>
272288
<language>en</language>
273289
</label>
274290
<label>
275-
<labelName>How many news ?</labelName>
291+
<labelName>Anzahl der Nachrichten</labelName>
276292
<language>de</language>
277293
</label>
278294
<parameter>
@@ -323,6 +339,10 @@
323339
<name>values</name>
324340
<value lang="en">Yes##No</value>
325341
</parameter>
342+
<parameter>
343+
<name>values</name>
344+
<value lang="de">Ja##Nein</value>
345+
</parameter>
326346
<parameter>
327347
<name>default</name>
328348
<value lang="fr">1</value>
@@ -367,6 +387,10 @@
367387
<name>values</name>
368388
<value lang="en">Yes##No</value>
369389
</parameter>
390+
<parameter>
391+
<name>values</name>
392+
<value lang="de">Ja##Nein</value>
393+
</parameter>
370394
<parameter>
371395
<name>default</name>
372396
<value lang="fr">0</value>
@@ -411,6 +435,10 @@
411435
<name>values</name>
412436
<value lang="en">Yes##No</value>
413437
</parameter>
438+
<parameter>
439+
<name>values</name>
440+
<value lang="de">Ja##Nein</value>
441+
</parameter>
414442
<isSearchable>false</isSearchable>
415443
<isFacet>false</isFacet>
416444
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -451,6 +479,10 @@
451479
<name>values</name>
452480
<value lang="en">Yes##No</value>
453481
</parameter>
482+
<parameter>
483+
<name>values</name>
484+
<value lang="de">Ja##Nein</value>
485+
</parameter>
454486
<isSearchable>false</isSearchable>
455487
<isFacet>false</isFacet>
456488
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -487,6 +519,10 @@
487519
<name>values</name>
488520
<value lang="en">Yes, about the entire platform##Yes, only on this subspace##No</value>
489521
</parameter>
522+
<parameter>
523+
<name>values</name>
524+
<value lang="de">Ja, über die gesamte Plattform##Ja, nur auf diesem Unterraum##Nein</value>
525+
</parameter>
490526
<isSearchable>false</isSearchable>
491527
<isFacet>false</isFacet>
492528
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -699,6 +735,10 @@
699735
<name>values</name>
700736
<value lang="en">Open in a new tab</value>
701737
</parameter>
738+
<parameter>
739+
<name>values</name>
740+
<value lang="de">In einem neuen Tab öffnen</value>
741+
</parameter>
702742
<isSearchable>false</isSearchable>
703743
<isFacet>false</isFacet>
704744
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -811,6 +851,10 @@
811851
<name>values</name>
812852
<value lang="en">Open in a new tab</value>
813853
</parameter>
854+
<parameter>
855+
<name>values</name>
856+
<value lang="de">In einem neuen Tab öffnen</value>
857+
</parameter>
814858
<isSearchable>false</isSearchable>
815859
<isFacet>false</isFacet>
816860
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -923,6 +967,10 @@
923967
<name>values</name>
924968
<value lang="en">Open in a new tab</value>
925969
</parameter>
970+
<parameter>
971+
<name>values</name>
972+
<value lang="de">In einem neuen Tab öffnen</value>
973+
</parameter>
926974
<isSearchable>false</isSearchable>
927975
<isFacet>false</isFacet>
928976
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -1033,7 +1081,11 @@
10331081
</parameter>
10341082
<parameter>
10351083
<name>values</name>
1036-
<value lang="eb">Open in a new tab</value>
1084+
<value lang="en">Open in a new tab</value>
1085+
</parameter>
1086+
<parameter>
1087+
<name>values</name>
1088+
<value lang="de">In einem neuen Tab öffnen</value>
10371089
</parameter>
10381090
<isSearchable>false</isSearchable>
10391091
<isFacet>false</isFacet>
@@ -1143,6 +1195,10 @@
11431195
<name>values</name>
11441196
<value lang="en">Open in a new tab</value>
11451197
</parameter>
1198+
<parameter>
1199+
<name>values</name>
1200+
<value lang="de">In einem neuen Tab öffnen</value>
1201+
</parameter>
11461202
<isSearchable>false</isSearchable>
11471203
<isFacet>false</isFacet>
11481204
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -1255,6 +1311,10 @@
12551311
<name>values</name>
12561312
<value lang="en">Open in a new tab</value>
12571313
</parameter>
1314+
<parameter>
1315+
<name>values</name>
1316+
<value lang="de">In einem neuen Tab öffnen</value>
1317+
</parameter>
12581318
<isSearchable>false</isSearchable>
12591319
<isFacet>false</isFacet>
12601320
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>
@@ -1399,6 +1459,10 @@
13991459
<name>values</name>
14001460
<value lang="en">Yes##No</value>
14011461
</parameter>
1462+
<parameter>
1463+
<name>values</name>
1464+
<value lang="de">Ja##Nein</value>
1465+
</parameter>
14021466
<isSearchable>false</isSearchable>
14031467
<isFacet>false</isFacet>
14041468
<maximumNumberOfOccurrences>1</maximumNumberOfOccurrences>

0 commit comments

Comments
 (0)