Skip to content

Commit 63619eb

Browse files
committed
Bug #14387 Takes into account the redirection parameters are now defined
into the new class WebRedirection in Silverpeas Core.
1 parent ec054bd commit 63619eb

File tree

2 files changed

+15
-10
lines changed

2 files changed

+15
-10
lines changed

aurora/aurora-war/src/main/java/org/silverpeas/looks/aurora/LookAuroraHelper.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import org.silverpeas.components.rssaggregator.model.SPChannel;
1717
import org.silverpeas.components.rssaggregator.service.RSSService;
1818
import org.silverpeas.components.rssaggregator.service.RSSServiceProvider;
19+
import org.silverpeas.core.web.util.WebRedirection;
1920
import org.silverpeas.kernel.SilverpeasRuntimeException;
2021
import org.silverpeas.core.admin.component.model.ComponentInst;
2122
import org.silverpeas.core.admin.component.model.ComponentInstLight;
@@ -603,7 +604,7 @@ public BodyPartSettings getBodyPartSettings(HttpServletRequest request) {
603604
BodyPartSettings bodyPartSettings = new BodyPartSettings();
604605

605606
HttpSession session = request.getSession();
606-
String strGoToNew = (String) session.getAttribute("gotoNew");
607+
String strGoToNew = (String) session.getAttribute(WebRedirection.REDIRECT_URL);
607608
String spaceId = request.getParameter("SpaceId");
608609
String subSpaceId = request.getParameter("SubSpaceId");
609610
String fromTopBar = request.getParameter("FromTopBar");
@@ -644,9 +645,9 @@ public BodyPartSettings getBodyPartSettings(HttpServletRequest request) {
644645
displayLoginHomepage, loginHomepage);
645646

646647
session.removeAttribute("goto");
647-
session.removeAttribute("gotoNew");
648-
session.removeAttribute("RedirectToComponentId");
649-
session.removeAttribute("RedirectToSpaceId");
648+
session.removeAttribute(WebRedirection.REDIRECT_URL);
649+
session.removeAttribute(WebRedirection.REDIRECT_TO_COMPONENT);
650+
session.removeAttribute(WebRedirection.REDIRECT_TO_SPACE);
650651

651652
boolean hideMenu = "1".equals(fromTopBar) || "1".equals(login);
652653
if (hideMenu) {

aurora/aurora-war/src/main/webapp/look/jsp/MainFrame.jsp

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
<%@ page import="org.silverpeas.kernel.bundle.ResourceLocator" %>
44
<%@ page import="org.silverpeas.kernel.bundle.LocalizationBundle" %>
55
<%@ page import="org.silverpeas.core.web.look.LookHelper" %>
6+
<%@ page import="org.silverpeas.core.web.util.WebRedirection" %>
7+
<%@ page import="static org.silverpeas.core.web.util.WebRedirection.REDIRECT_TO_COMPONENT" %>
8+
<%@ page import="static org.silverpeas.core.web.util.WebRedirection.REDIRECT_TO_SPACE" %>
9+
<%@ page import="static org.silverpeas.core.web.util.WebRedirection.*" %>
610
<%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c"%>
711
<%@ taglib uri="http://java.sun.com/jsp/jstl/fmt" prefix="fmt"%>
812
<%@ taglib uri="http://www.silverpeas.com/tld/viewGenerator" prefix="view"%>
@@ -17,12 +21,12 @@
1721

1822

1923
<%
20-
String componentIdFromRedirect = (String) session.getAttribute("RedirectToComponentId");
21-
String spaceIdFromRedirect = (String) session.getAttribute("RedirectToSpaceId");
24+
String componentIdFromRedirect = (String) session.getAttribute(REDIRECT_TO_COMPONENT);
25+
String spaceIdFromRedirect = (String) session.getAttribute(REDIRECT_TO_SPACE);
2226
if (!StringUtil.isDefined(spaceIdFromRedirect)) {
23-
spaceIdFromRedirect = request.getParameter("RedirectToSpaceId");
27+
spaceIdFromRedirect = request.getParameter(REDIRECT_TO_SPACE);
2428
}
25-
String attachmentId = (String) session.getAttribute("RedirectToAttachmentId");
29+
String attachmentId = (String) session.getAttribute(REDIRECT_TO_ATTACHMENT);
2630
LocalizationBundle generalMessage = ResourceLocator.getGeneralLocalizationBundle(language);
2731
StringBuilder frameBottomParams = new StringBuilder().append("{");
2832
boolean login = StringUtil.getBooleanValue(request.getParameter("Login"));
@@ -73,7 +77,7 @@ if (m_MainSessionCtrl == null) { %>
7377
}
7478
7579
if (!thisFrame.equalsIgnoreCase(helper.getMainFrame())) {
76-
session.setAttribute("RedirectToSpaceId", spaceIdFromRedirect);
80+
session.setAttribute(REDIRECT_TO_SPACE, spaceIdFromRedirect);
7781
%>
7882
<script type="text/javascript">
7983
top.location="<%=helper.getMainFrame()%>";
@@ -154,7 +158,7 @@ if (m_MainSessionCtrl == null) { %>
154158
</view:sp-head-part>
155159
<view:sp-body-part>
156160
<% if (attachmentId != null) {
157-
session.setAttribute("RedirectToAttachmentId", null);
161+
session.setAttribute(REDIRECT_TO_ATTACHMENT, null);
158162
%>
159163
<script type="text/javascript">
160164
SP_openWindow('<%=m_sContext%>/File/<%=attachmentId%>', 'Fichier', '800', '600', 'directories=0,menubar=1,toolbar=1,scrollbars=1,location=1,alwaysRaised');

0 commit comments

Comments
 (0)