Use JUnit 5 convention for class visibility

Author: garydgregory

src/test/java/org/apache/commons/codec/CharEncodingTest.java

@@ -26,7 +26,7 @@
 /**
  * Sanity checks for {@link CharEncoding}.
  */
-public class CharEncodingTest {
+class CharEncodingTest {
 
     /**
      * We could make the constructor private in the future, it's a matter a style.

src/test/java/org/apache/commons/codec/CharsetsTest.java

@@ -31,7 +31,7 @@
 /**
  * Sanity checks for {@link Charsets}.
  */
-public class CharsetsTest {
+class CharsetsTest {
 
     private static final TreeSet<String> AVAILABLE_CHARSET_NAMES = new TreeSet<>(Charset.availableCharsets().keySet());
 

src/test/java/org/apache/commons/codec/DecoderExceptionTest.java

@@ -25,7 +25,7 @@
 /**
  * Tests {@link DecoderException}.
  */
-public class DecoderExceptionTest {
+class DecoderExceptionTest {
 
     private static final String MSG = "TEST";
 

src/test/java/org/apache/commons/codec/EncoderExceptionTest.java

@@ -25,7 +25,7 @@
 /**
  * Tests {@link EncoderException}.
  */
-public class EncoderExceptionTest {
+class EncoderExceptionTest {
 
     private static final String MSG = "TEST";
 

src/test/java/org/apache/commons/codec/ResourcesTest.java

@@ -28,7 +28,7 @@
 /**
  * Tests {@link Resources}.
  */
-public class ResourcesTest {
+class ResourcesTest {
 
     static List<String> getResourceNames() {
         return Arrays.asList("/org/apache/commons/codec/language/dmrules.txt", "/org/apache/commons/codec/language/bm/lang.txt");

src/test/java/org/apache/commons/codec/StringEncoderComparatorTest.java

@@ -30,7 +30,7 @@
 /**
  * Test cases for the StingEncoderComparator.
  */
-public class StringEncoderComparatorTest {
+class StringEncoderComparatorTest {
 
     @SuppressWarnings("unchecked") // cannot easily avoid this warning
     @Test

src/test/java/org/apache/commons/codec/binary/AllocateDirectHexTest.java

@@ -19,7 +19,7 @@
 
 import java.nio.ByteBuffer;
 
-public class AllocateDirectHexTest extends HexTest {
+class AllocateDirectHexTest extends HexTest {
 
     @Override
     protected ByteBuffer allocate(final int capacity) {

src/test/java/org/apache/commons/codec/binary/Base16InputStreamTest.java

@@ -31,7 +31,7 @@
 /**
  * Tests {@link Base16InputStream}.
  */
-public class Base16InputStreamTest {
+class Base16InputStreamTest {
 
     /**
      * Decodes to {202, 254, 186, 190, 255, 255}

src/test/java/org/apache/commons/codec/binary/Base16OutputStreamTest.java

@@ -29,7 +29,7 @@
 /**
  * Tests {@link Base16OutputStream}.
  */
-public class Base16OutputStreamTest {
+class Base16OutputStreamTest {
 
     private static final String STRING_FIXTURE = "Hello World";
 

src/test/java/org/apache/commons/codec/binary/Base16Test.java

@@ -37,7 +37,7 @@
 /**
  * Tests {@link Base16}.
  */
-public class Base16Test {
+class Base16Test {
 
     private static final Charset CHARSET_UTF8 = StandardCharsets.UTF_8;
 

src/test/java/org/apache/commons/codec/binary/Base32InputStreamTest.java

@@ -34,7 +34,7 @@
 /**
  * Tests {@link Base32InputStream}.
  */
-public class Base32InputStreamTest {
+class Base32InputStreamTest {
 
     private static final String ENCODED_FOO = "MZXW6===";
 

src/test/java/org/apache/commons/codec/binary/Base32OutputStreamTest.java

@@ -31,7 +31,7 @@
 /**
  * Tests {@link Base32OutputStream}.
  */
-public class Base32OutputStreamTest {
+class Base32OutputStreamTest {
 
     private static final byte[] CR_LF = {(byte) '\r', (byte) '\n'};
 

src/test/java/org/apache/commons/codec/binary/Base32Test.java

@@ -38,7 +38,7 @@
 /**
  * Tests {@link Base32}.
  */
-public class Base32Test {
+class Base32Test {
 
     private static final Charset CHARSET_UTF8 = StandardCharsets.UTF_8;
 

src/test/java/org/apache/commons/codec/binary/Base64Codec13Test.java

@@ -33,7 +33,7 @@
  * Tests to make sure future versions of commons-codec.jar have identical Base64
  * behavior as commons-codec-1.3.jar.
  */
-public class Base64Codec13Test {
+class Base64Codec13Test {
 
     private static final String[] STRINGS = new String[181];
     private static final String[] CHUNKED_STRINGS = new String[STRINGS.length];

src/test/java/org/apache/commons/codec/binary/Base64InputStreamTest.java

@@ -37,7 +37,7 @@
 /**
  * Tests {@link Base64InputStream}.
  */
-public class Base64InputStreamTest {
+class Base64InputStreamTest {
 
     /**
      * Decodes to {0, 0, 0, 255, 255, 255}

src/test/java/org/apache/commons/codec/binary/Base64OutputStreamTest.java

@@ -32,7 +32,7 @@
 /**
  * Tests {@link Base64OutputStream}.
  */
-public class Base64OutputStreamTest {
+class Base64OutputStreamTest {
 
     private static final byte[] CR_LF = {(byte) '\r', (byte) '\n'};
 

src/test/java/org/apache/commons/codec/binary/Base64Test.java

@@ -44,7 +44,7 @@
  *
  * @see <a href="http://www.ietf.org/rfc/rfc2045.txt">RFC 2045</a>
  */
-public class Base64Test {
+class Base64Test {
 
     private static final String FOX_BASE64 = "VGhlIH@$#$@%F1aWN@#@#@@rIGJyb3duIGZve\n\r\t%#%#%#%CBqd##$#$W1wZWQgb3ZlciB0aGUgbGF6eSBkb2dzLg==";
 

src/test/java/org/apache/commons/codec/binary/BaseNCodecTest.java

@@ -29,7 +29,7 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public class BaseNCodecTest {
+class BaseNCodecTest {
 
     /**
      * Extend BaseNCodec without implementation (no operations = NoOp).

src/test/java/org/apache/commons/codec/binary/BinaryCodecTest.java

@@ -32,7 +32,7 @@
 /**
  * TestCase for BinaryCodec class.
  */
-public class BinaryCodecTest {
+class BinaryCodecTest {
 
     private static final Charset CHARSET_UTF8 = StandardCharsets.UTF_8;
 

src/test/java/org/apache/commons/codec/binary/CharSequenceUtilsTest.java

@@ -31,7 +31,7 @@
  * the method is package private. The failing tests have been commented out and the
  * implementation left unchanged.
  */
-public class CharSequenceUtilsTest {
+class CharSequenceUtilsTest {
 
     private abstract static class RunTest {
 

src/test/java/org/apache/commons/codec/binary/HexTest.java

@@ -40,7 +40,7 @@
 /**
  * Tests {@link org.apache.commons.codec.binary.Hex}.
  */
-public class HexTest {
+class HexTest {
 
     private static final String BAD_ENCODING_NAME = "UNKNOWN";
 

src/test/java/org/apache/commons/codec/binary/StringUtilsTest.java

@@ -33,7 +33,7 @@
 /**
  * Tests {@link StringUtils}
  */
-public class StringUtilsTest {
+class StringUtilsTest {
 
     private static final byte[] BYTES_FIXTURE = { 'a', 'b', 'c' };
 

src/test/java/org/apache/commons/codec/cli/DigestTest.java

@@ -24,7 +24,7 @@
 /**
  * Tests {@link Digest}.
  */
-public class DigestTest {
+class DigestTest {
 
     /**
      * Tests if empty arguments are handled correctly.

src/test/java/org/apache/commons/codec/digest/Apr1CryptTest.java

@@ -26,7 +26,7 @@
 
 import org.junit.jupiter.api.Test;
 
-public class Apr1CryptTest {
+class Apr1CryptTest {
 
     @Test
     void testApr1CryptBytes() {

src/test/java/org/apache/commons/codec/digest/B64Test.java

@@ -21,7 +21,7 @@
 
 import org.junit.jupiter.api.Test;
 
-public class B64Test {
+class B64Test {
 
     @Test
     void testB64from24bit() {

src/test/java/org/apache/commons/codec/digest/Blake3Test.java

@@ -20,7 +20,7 @@
 
 import org.junit.jupiter.api.Test;
 
-public class Blake3Test {
+class Blake3Test {
     private static void assertThrowsProperExceptionWithKeySize(final int keySize) {
         assertThrows(IllegalArgumentException.class, () -> Blake3.initKeyedHash(new byte[keySize]), "Blake3 keys must be 32 bytes");
     }

src/test/java/org/apache/commons/codec/digest/Blake3TestVectorsTest.java

@@ -37,7 +37,7 @@
  * For each of these hashes, both the extended hash output and the truncated 32-byte hash outputs are validated against
  * these known answer tests (KATs).
  */
-public class Blake3TestVectorsTest {
+class Blake3TestVectorsTest {
     private static final byte[] KEY = "whats the Elvish word for friend".getBytes(StandardCharsets.UTF_8);
     private static final byte[] CTX =
             "BLAKE3 2019-12-27 16:29:52 test vectors context".getBytes(StandardCharsets.UTF_8);

src/test/java/org/apache/commons/codec/digest/CryptTest.java

@@ -23,7 +23,7 @@
 
 import org.junit.jupiter.api.Test;
 
-public class CryptTest {
+class CryptTest {
 
     // Allow CLI testing
     // CLASSPATH=target/classes:target/test-classes/ java org.apache.commons.codec.digest.CryptTest

src/test/java/org/apache/commons/codec/digest/DigestUtilsTest.java

@@ -51,7 +51,7 @@
 /**
  * Tests {@link DigestUtils}.
  */
-public class DigestUtilsTest {
+class DigestUtilsTest {
 
     private static final String EMPTY_STRING = "";
 

src/test/java/org/apache/commons/codec/digest/HmacAlgorithmsTest.java

@@ -49,7 +49,7 @@
 /**
  * Tests {@link HmacAlgorithms}.
  */
-public class HmacAlgorithmsTest {
+class HmacAlgorithmsTest {
 
     static final String STANDARD_KEY_STRING = "key";
 

src/test/java/org/apache/commons/codec/digest/HmacUtilsTest.java

@@ -33,7 +33,7 @@
 /**
  * Tests {@link HmacUtils}.
  */
-public class HmacUtilsTest {
+class HmacUtilsTest {
 
     @SuppressWarnings("deprecation") // most of the static methods are deprecated
     @Test

src/test/java/org/apache/commons/codec/digest/Md5CryptTest.java

@@ -30,7 +30,7 @@
 import org.junit.jupiter.api.Timeout;
 
 @Timeout(3) // Try to avoid occaisional hang when testing
-public class Md5CryptTest {
+class Md5CryptTest {
 
     @Test
     void testCtor() {

src/test/java/org/apache/commons/codec/digest/MessageDigestAlgorithmsTest.java

@@ -45,7 +45,7 @@
 /**
  * Tests {@link MessageDigestAlgorithms}.
  */
-public class MessageDigestAlgorithmsTest {
+class MessageDigestAlgorithmsTest {
 
     @BeforeAll
     public static void checkValues() throws Exception {

src/test/java/org/apache/commons/codec/digest/MurmurHash2Test.java

@@ -22,7 +22,7 @@
 
 import org.junit.jupiter.api.Test;
 
-public class MurmurHash2Test {
+class MurmurHash2Test {
 
     /** Random input data with various length. */
     static final byte[][] input = {

src/test/java/org/apache/commons/codec/digest/MurmurHash3Test.java

@@ -36,7 +36,7 @@
  * Test for {@link MurmurHash3}.
  */
 @SuppressWarnings("deprecation")
-public class MurmurHash3Test {
+class MurmurHash3Test {
 
     /** Test data for the hash64 method. */
     private static final String TEST_HASH64 = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum. Sed ut perspiciatis unde omnis iste natus error sit voluptatem accusantium doloremque laudantium, totam rem aperiam, eaque ipsa quae ab illo inventore veritatis et quasi architecto beatae vitae dicta sunt explicabo. Nemo enim ipsam voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione voluptatem sequi nesciunt. Neque porro quisquam est, qui dolorem ipsum quia dolor sit amet, consectetur, adipisci velit, sed quia non numquam eius modi tempora incidunt ut labore et dolore magnam aliquam quaerat voluptatem. Ut enim ad minima veniam, quis nostrum exercitationem ullam corporis suscipit laboriosam, nisi ut aliquid ex ea commodi consequatur? Quis autem vel eum iure reprehenderit qui in ea voluptate velit esse quam nihil molestiae consequatur, vel illum qui dolorem eum fugiat quo voluptas nulla pariatur?";

src/test/java/org/apache/commons/codec/digest/PureJavaCrc32CTest.java

@@ -25,7 +25,7 @@
 /**
  * Tests {@link PureJavaCrc32C}. Test data was derived from https://tools.ietf.org/html/rfc3720#appendix-B.4
  */
-public class PureJavaCrc32CTest {
+class PureJavaCrc32CTest {
 
     private final PureJavaCrc32C crc = new PureJavaCrc32C();
 

src/test/java/org/apache/commons/codec/digest/PureJavaCrc32Test.java

@@ -38,7 +38,7 @@
  *
  * Copied from Hadoop 2.6.3 (Renamed TestPureJavaCrc32 to PureJavaCrc32Test).
  */
-public class PureJavaCrc32Test {
+class PureJavaCrc32Test {
 
     /**
      * Performance tests to compare performance of the Pure Java implementation to the built-in java.util.zip implementation. This can be run from the command

src/test/java/org/apache/commons/codec/digest/Sha256CryptTest.java

@@ -27,7 +27,7 @@
 
 import org.junit.jupiter.api.Test;
 
-public class Sha256CryptTest {
+class Sha256CryptTest {
 
     @Test
     void testSha256CryptBytes() {

src/test/java/org/apache/commons/codec/digest/Sha2CryptTest.java

@@ -21,7 +21,7 @@
 
 import org.junit.jupiter.api.Test;
 
-public class Sha2CryptTest {
+class Sha2CryptTest {
 
     @Test
     void testCtor() {

src/test/java/org/apache/commons/codec/digest/Sha512CryptTest.java

@@ -28,7 +28,7 @@
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
-public class Sha512CryptTest {
+class Sha512CryptTest {
 
     @Test
     void testSha256LargetThanBlocksize() {

src/test/java/org/apache/commons/codec/digest/UnixCryptTest.java

@@ -29,7 +29,7 @@
 /**
  * Tests {@link UnixCrypt}.
  */
-public class UnixCryptTest {
+class UnixCryptTest {
 
     @Test
     void testCtor() {

src/test/java/org/apache/commons/codec/digest/XXHash32OverflowTest.java

@@ -21,7 +21,7 @@
 
 import org.junit.jupiter.api.Test;
 
-public class XXHash32OverflowTest {
+class XXHash32OverflowTest {
 
     /**
      * This test hits an edge case where a very large number of bytes is added to the incremental

src/test/java/org/apache/commons/codec/digest/XXHash32Test.java

@@ -34,7 +34,7 @@
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
 
-public class XXHash32Test {
+class XXHash32Test {
 
     private static long copy(final InputStream input, final OutputStream output, final int bufferSize) throws IOException {
         return IOUtils.copyLarge(input, output, new byte[bufferSize]);

src/test/java/org/apache/commons/codec/language/Caverphone1Test.java

@@ -27,7 +27,7 @@
 /**
  * Tests Caverphone1.
  */
-public class Caverphone1Test extends AbstractStringEncoderTest<Caverphone1> {
+class Caverphone1Test extends AbstractStringEncoderTest<Caverphone1> {
 
     @Override
     protected Caverphone1 createStringEncoder() {