Skip to content

Conversation

@zabetak
Copy link
Member

@zabetak zabetak commented Jun 3, 2025

What changes were proposed in this pull request?

Introduce ephemeral storage request and limit for HDB container based on current usage and cluster capacity.

Why are the changes needed?

Based on recent runs the HDB container, which executes the tests, consumes 10Gi to 15Gi of ephemeral storage. To ensure that pods are scheduled correctly to the GKE nodes that have the necessary capacity we should add an explicit resource request.

Moreover, to avoid malfunctioning PRs/pods affect the overall health of the cluster we set the resource limit to 20Gi that is reasonably high to permit precommits to run fine and can also guard against accidental changes that may cause disk spikes.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Monitor requests/limits through the GKE console.

Introduce ephemeral storage request and limit for HDB container based on current usage and cluster capacity.

Based on recent runs the HDB container, which executes the tests, consumes 10Gi to 15Gi of ephemeral storage. To ensure that pods are scheduled correctly to the GKE nodes that have the necessary capacity we should add an explicit resource request.

Moreover, to avoid malfunctioning PRs/pods affect the overall health of the cluster we set the resource limit to 20Gi that is reasonably high to permit precommits to run fine and can also guard against accidental changes that may cause disk spikes.
@kokila-19
Copy link
Contributor

LGTM +1
There is one test failure which is flaky , re-triggering should pass the tests.

@sonarqubecloud
Copy link

Copy link
Contributor

@tanishq-chugh tanishq-chugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zabetak zabetak merged commit 32eedb2 into apache:master Jun 24, 2025
6 checks passed
@zabetak zabetak deleted the HIVE-28954 branch June 24, 2025 14:16
@zabetak
Copy link
Member Author

zabetak commented Jun 24, 2025

Thanks everyone for the reviews! Much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants