-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-29000: Upgrade nimbus-jose-jwt to 10.4.2 to resolve CVE #5855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@arorasimran0309 , I can still see nimbus older version in iceberg/patched-iceberg-core/pom.xml
Also, this is a major version change, please check for any incompatiblities in api's (from release notes). As we are forcing hadoop 3.4.1 to work with 10.3 instead of 9.37.2 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
<exclusion> | ||
<groupId>com.nimbusds</groupId> | ||
<artifactId>nimbus-jose-jwt</artifactId> | ||
</exclusion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the same exclusion here as well: https://github.com/apache/hive/blob/master/standalone-metastore/metastore-common/pom.xml#L77 to avoid 9.37.3 completely from the dependency tree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed these changes, please review
44b523e
to
c8ae04e
Compare
c8ae04e
to
9986224
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1, Pending green Jenkins tests.
|
@Aggarwal-Raghav |
Waiting for @Aggarwal-Raghav's approval to merge this patch |
Dependency tree looks good, packaing also contains onty nimbus-jose-jwt-10.4.2.jar. |
What changes were proposed in this pull request?
Upgrading nimbus-jose-jwt to resolve CVEs
Why are the changes needed?
Due to CVEs
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests, dependency tree