Create a new modelVersion 4.2.0 #2475
Conversation
compat/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.2.0.xml
Outdated
Show resolved
Hide resolved
impl/maven-impl/src/main/resources/org/apache/maven/model/pom-4.2.0.xml
Outdated
Show resolved
Hide resolved
| @@ -20,8 +20,9 @@ under the License. | |||
| --> | |||
|
|
|||
| <!-- START SNIPPET: superpom --> | |||
| <project> | |||
| <modelVersion>4.0.0</modelVersion> | |||
| <project xmlns="http://maven.apache.org/POM/4.1.0" | |||
There was a problem hiding this comment.
I'm not sure where we've landed on this, but this is still wrong. The namespace should not be changing with every model version, and the sooner we fix that the better. This is what model versions are for.
| --> | ||
|
|
||
| <!-- START SNIPPET: superpom --> | ||
| <project xmlns="http://maven.apache.org/POM/4.2.0" |
There was a problem hiding this comment.
No. Do not increment the namespace. This is wrong.
|
I know your stance, and don't really disagree. Unfortunately, that ships has sailed a while ago, and 4.0.0 is nearly out the door. So if we want to schedule such a change, I think we need to target 5.0 and discuss how to do that. |
gnodet
force-pushed
the
model-4.2.0
branch
2 times, most recently
from
4786ff0 to
9ff560f
Compare
|
I'm going to merge this PR so that I can merge #1209 correctly. |
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This PR introduces a new 4.2.0 model, needed to introduce new model changes such as mixins.