Add quotes in the command-line arguments formatted by JavaPathType.

[desruisseaux]

The main purpose of this pull request is to put the file paths between quotes in the command line. For example instead of:

--module-source-path my.module=src/foo:src/bar

Format as:

--module-source-path my.module="src/foo:src/bar"

This pull request also contains opportunistic Javadoc formatting: missing dots at the end of summary sentences, missing closing </p> HTML tag.

[elharo]

This needs a JIRA issue or Github issue, whichever using right now

[elharo]

This needs a test

[desruisseaux]

Test added.

[desruisseaux]

Regarding the JIRA ticket, I think that the migration to GitHub is done. The JIRA page for Maven now said "Maven (Moved to GitHub Issues)" and I don't see a "Create" button.

Given that a pull request on GitHub is practically identical to a GitHub issue + code, do we really need a separated GitHub issue?

[elharo]

Yes, I think we need a separate issue. It's used for the release notes.

[gnodet]

This needs a JIRA issue or Github issue, whichever using right now

That's not true afaik. The release notes are built from issues and PRs, so we don't need an issue for each PR.

[olamy]

This needs a JIRA issue or Github issue, whichever using right now

That's not true afaik. The release notes are built from issues and PRs, so we don't need an issue for each PR.

agree and stated here https://maven.apache.org/developers/conventions/github.html

When you provide a Pull Request - creating separate issue is not necessary as you can describe your proposition in Pull Request.

[elharo]

This needs a JIRA issue or Github issue, whichever using right now

That's not true afaik. The release notes are built from issues and PRs, so we don't need an issue for each PR.

agree and stated here https://maven.apache.org/developers/conventions/github.html

When you provide a Pull Request - creating separate issue is not necessary as you can describe your proposition in Pull Request.

OK, so not required for the relase notes but still required and good idea. Per the page you cite, "A GitHub Issue should be created to report a bug or request a new feature." With Jira we had pretty good bug tracker records. Let's keep that up.

still think this needs an issue, but won't block on that

[gnodet]

This needs a JIRA issue or Github issue, whichever using right now

That's not true afaik. The release notes are built from issues and PRs, so we don't need an issue for each PR.

agree and stated here https://maven.apache.org/developers/conventions/github.html

When you provide a Pull Request - creating separate issue is not necessary as you can describe your proposition in Pull Request.

OK, so not required for the relase notes but still required and good idea. Per the page you cite, "A GitHub Issue should be created to report a bug or request a new feature." With Jira we had pretty good bug tracker records. Let's keep that up.

Issues and PRs are really the same. The difference is that when you don't have code and you just report something, you create an issue. When you actually fix something, we just create a PR. Creating an issue for each PR is redundant and does not bring anything in GitHub. Both issues and PRs are assigned to milestones/releases, so having both systematically is actually confusing, because it creates lots of duplicates.

[elharo]

I disagree that issues and PRs are the same. They are very different things with different purposes, and if I'd thought moving to github issues meant we were going to stop using issues, I would have argued against it. Our development practices are going backwards.

[gnodet]

I disagree that issues and PRs are the same. They are very different things with different purposes, and if I'd thought moving to github issues meant we were going to stop using issues, I would have argued against it. Our development practices are going backwards.

@elharo Can you be more explicit about what you think we're loosing ? I really don't see.