-
Notifications
You must be signed in to change notification settings - Fork 897
update UseSuperTypeTest for jdk 21 #8446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove "solves issue 8445" from the commit message.
feel free to squash + rebase right away with the modifications since this is a smaller diff
I am going to update the PR title and link the PR to the issue. Btw we typically don't create issues for PRs if we plan to fix the problem anyway.
...actoring.java/test/unit/src/org/netbeans/modules/refactoring/java/test/UseSuperTypeTest.java
Outdated
Show resolved
Hide resolved
...actoring.java/test/unit/src/org/netbeans/modules/refactoring/java/test/UseSuperTypeTest.java
Outdated
Show resolved
Hide resolved
fyi: the email address on this commit is not the same as on your other commits |
I know. The other email address was from the time when I joined GitHub. It is an email address I can no longer access. |
the second commit has now the right email address I believe. Whats left is to:
squashing works like this: $ git log --oneline
c4a0768b8 (HEAD -> issue8445) repair email address
3984a77b5 solves issue 8445
256edf4e9 (origin/master, master) Merge pull request #8604 from mbien/vue-css-prerequisite
... lets say you want to squash the last two commits on top of that list and there is no merge commit in between git rebase --autostash -i HEAD~2 this will open an editor with the following content pick 3984a77b5 solves issue 8445
pick c4a0768b8 repair email address
# Rebase 256edf4e9..c4a0768b8 onto 256edf4e9 (2 commands)
#
# Commands:
... (more instructions) By editing the second item on the list and changing A well formatted commit message has a short description in the first line, then a blank line, then more info if needed. update UseSuperTypeTest for jdk 21
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
... (more info) thats it, now check the log again and it should look like: $ git log --oneline
eee9647b3 (HEAD -> issue8445) update UseSuperTypeTest for jdk 21
256edf4e9 (origin/master, master) Merge pull request #8604 from mbien/vue-css-prerequisite
219724b1d Add build-prerequisite flag to css.prep dep of javascript2.vue Now in NetBeans, lets say you want to add something to the last commit without using the shell, simply use the commit action as usual, but check "Amend Last Commit" on the commit window. This will add the changes to the last commit, and also replace the commit message. force push into the PR branch and it should be good. (see #8575 (comment)) |
b3fbffc
to
67abba7
Compare
Create expected code depending on java.version string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent - thanks for updating the test!
will merge once green
Create expected code depending on JDK version
closes #8445