Skip to content

Conversation

homberghp
Copy link
Contributor

@homberghp homberghp commented Jun 16, 2025

Check returned array value before using, avoiding NPE.

While working on an unrelated subject, I got an error notification that mentions an NPE in the modified file

Simply add a check of the return value before dereferencing it in the following for-each statement. The result is that no elements will be added to the list in the for-each loop, which looks okay to me in that case.

}
JSONArray array = (JSONArray)result.get("result"); // NOI18N
for (Object o : array) {
res.add(APIFactory.createPropertyDescriptor((JSONObject)o, webkit));
}
return res;


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@homberghp homberghp changed the title closes issue7828, NPE, check result before use prevent NPE, check return value before use Jun 23, 2025
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to reframe the commit message to:

Prevent NullPointerException in WebKit debugger code

Closes: #7828

@@ -74,7 +74,7 @@ public List<PropertyDescriptor> getRemoteObjectProperties(RemoteObject remoteObj
return Collections.emptyList();
}
JSONArray array = (JSONArray)result.get("result"); // NOI18N
for (Object o : array) {
if ( array != null ) for (Object o : array) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the style of the rest of the code and make this a full if-block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants