-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Sort Splunk logs by timestamp #5057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
...on/scala/src/main/scala/org/apache/openwhisk/core/containerpool/logging/SplunkLogStore.scala
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #5057 +/- ##
===========================================
+ Coverage 34.77% 71.09% +36.31%
===========================================
Files 200 200
Lines 9759 9759
Branches 441 441
===========================================
+ Hits 3394 6938 +3544
+ Misses 6365 2821 -3544
Continue to review full report at Codecov.
|
@mcdan Would it be ok to merge this PR? |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #5057 +/- ##
==========================================
- Coverage 82.50% 75.23% -7.27%
==========================================
Files 207 200 -7
Lines 10024 9759 -265
Branches 444 441 -3
==========================================
- Hits 8270 7342 -928
- Misses 1754 2417 +663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes an issue that was noticed when pulling logs from Splunk where logs were coming in unexpected order.
This PR will force logs to be
sorted by timestamp
first and then returned in areverse
order.My changes affect the following components
Types of changes
Checklist: