Skip to content

[ISSUE #9467]Implement paged retrieval of Topic and SubscriptionGroup information #9468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ltamber
Copy link
Contributor

@ltamber ltamber commented Jun 12, 2025

Which Issue(s) This PR Fixes

Fixes #9467

Brief Description

  • Implemented pagination logic to support data retrieval by sequence number and maximum count.
  • Added data version checking to ensure the retrieved data is the latest.
  • Optimized the result structure to include total count and current page data.
  • Added unit tests

How Did You Test This Change?

- Implemented pagination logic to support data retrieval by sequence number and maximum count.
- Added data version checking to ensure the retrieved data is the latest.
- Optimized the result structure to include total count and current page data.
- Added unit tests
@ltamber ltamber changed the title Implement paged retrieval of Topic and SubscriptionGroup information [ISSUE #9467]Implement paged retrieval of Topic and SubscriptionGroup information Jun 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 44.47674% with 191 lines in your changes missing coverage. Please review.

Project coverage is 48.01%. Comparing base (53a3f69) to head (6694aec).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...org/apache/rocketmq/broker/out/BrokerOuterAPI.java 0.00% 108 Missing ⚠️
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 64.28% 25 Missing and 10 partials ⚠️
...l/header/GetAllSubscriptionGroupRequestHeader.java 0.00% 11 Missing ⚠️
...rotocol/header/GetAllTopicConfigRequestHeader.java 0.00% 11 Missing ⚠️
.../java/org/apache/rocketmq/common/BrokerConfig.java 25.00% 6 Missing ⚠️
.../header/GetAllSubscriptionGroupResponseHeader.java 0.00% 5 Missing ⚠️
.../broker/subscription/SubscriptionGroupManager.java 76.47% 3 Missing and 1 partial ⚠️
...ocketmq/broker/topic/TopicQueueMappingManager.java 20.00% 3 Missing and 1 partial ⚠️
...otocol/header/GetAllTopicConfigResponseHeader.java 0.00% 3 Missing ⚠️
...ocketmq/broker/processor/AdminBrokerProcessor.java 96.55% 0 Missing and 2 partials ⚠️
... and 1 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9468      +/-   ##
=============================================
- Coverage      48.15%   48.01%   -0.15%     
+ Complexity     12027    12008      -19     
=============================================
  Files           1308     1311       +3     
  Lines          92253    92563     +310     
  Branches       11808    11838      +30     
=============================================
+ Hits           44425    44444      +19     
- Misses         42343    42607     +264     
- Partials        5485     5512      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

RongtongJin
RongtongJin previously approved these changes Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Implement paged retrieval of topic and subscription group information
3 participants