[ISSUE #9479] Relax topic length constraint when creating retry and dlq topics #9480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhimins
requested changes
Jun 17, 2025
Allenhuangrui
changed the title
|
add some unit test |
lizhimins
approved these changes
Jun 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9480 +/- ##
=============================================
- Coverage 48.15% 47.98% -0.18%
+ Complexity 12027 11984 -43
=============================================
Files 1308 1308
Lines 92253 92254 +1
Branches 11808 11810 +2
=============================================
- Hits 44425 44265 -160
- Misses 42343 42485 +142
- Partials 5485 5504 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lizhimins
approved these changes
Jun 30, 2025
WJ66880
pushed a commit
to WJ66880/rocketmq
that referenced
this pull request
Jul 1, 2025
… and dlq topics (apache#9480)
hechen0
pushed a commit
to hechen0/rocketmq
that referenced
this pull request
Aug 18, 2025
… and dlq topics (apache#9480)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9479
Brief Description
Add two more conditions in the if statement of validateTopic method to additionally check whether the validating topic is dlq or retry topic and if it is then skip the topic length validation.
How Did You Test This Change?
Built a snapshot of this change and tested creating dlq and retry topics of length greater than 127.