Skip to content

refactor: use button type for react and vue based on click listener #4490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025

Conversation

nmerget
Copy link
Collaborator

@nmerget nmerget commented Jul 8, 2025

Proposed changes

closes #2038

Types of changes

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improvements to existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

Copy link
Contributor

github-actions bot commented Jul 8, 2025

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/refactor-button-type

nmerget and others added 3 commits July 8, 2025 16:37
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Jul 9, 2025
@mfranzke mfranzke linked an issue Jul 9, 2025 that may be closed by this pull request
7 tasks
@nmerget nmerget merged commit 57aeb60 into 3.0-release Jul 9, 2025
66 of 69 checks passed
@nmerget nmerget deleted the refactor-button-type branch July 9, 2025 08:08
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in UX Engineering Team Backlog Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍄🆙improvement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Button: type is not specified in a lot of cases
2 participants