fix: auto close for sub-navigation click #4522
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-close-on-click |
NearW
approved these changes
Jul 11, 2025
mfranzke
reviewed
Jul 11, 2025
| handleNavigationItemClick: (event: unknown) => { | ||
| if (isEventTargetNavigationItem(event)) { | ||
| handleNavigationItemClick: (event: any) => { | ||
| if (event?.target?.nodeName === 'A') { |
There was a problem hiding this comment.
Suggested change
| if (event?.target?.nodeName === 'A') { | |
| if (event?.target?.nodeName.toLowerCase() === 'a') { |
mfranzke
reviewed
Jul 11, 2025
| @@ -130,7 +130,7 @@ export type PlacementProps = { | |||
| }; | |||
|
|
|||
| export type NavigationBehaviorState = { | |||
| handleNavigationItemClick: (event: unknown) => void; | |||
| handleNavigationItemClick: (event: any) => void; | |||
There was a problem hiding this comment.
why do you switch from unknown to any ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
closes #4189
Types of changes
Further comments