blindspot on RemoveUnusedImportsStep
#2533
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
force-pushed
the
fix-testRemoveUnusedInports-pr
branch
from
9556bf9 to
f6cb9d2
Compare
|
seems the new test does not pass |
|
yes sorry this needs to be covered in google as spot has no dedicated impl. |
|
actually google-java-format looks kind of dead as there is no response, also not on 2 month old tickets. |
|
as its just c&p ether its might be an good idea to take the impl from palantir, as this repo seems to be maintained, making a fix possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #2532 blindspot on
RemoveUnusedImportsStep