Skip to content

Remove support for Windows Server 2019 / 1809 #19138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025

Conversation

tianon
Copy link
Member

@tianon tianon commented May 30, 2025

@tianon
Copy link
Member Author

tianon commented May 30, 2025

FYI affected maintainers for the Windows Server 2019/1809 removal:

Please either drop the affected tags from the supported list (by removing them from your library/ file) or update them to a supported release.

(Also, if you're not supposed to be in this list, or you're getting this forwarded to you and you are supposed to be in this list, please update the Maintainers: section of the relevant library/ file appropriately! 😅)

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@francislavoie
Copy link
Contributor

@tianon do you have a recommendation for which versions of windows images Caddy should support? I honestly don't even know if anyone uses those at all, I don't understand why anyone would frankly 😂

@tianon
Copy link
Member Author

tianon commented Jun 4, 2025

Ultimately that's up to you - if you think users of Windows Containers should have a Caddy image, then the full intersection of versions you're willing to build/support and the versions we're willing to accept is useful because of how picky they tend to be about the underlying OS version matching the host OS version, in practice. That's currently somewhere even to or south of "ltsc2022 + ltsc2025". On the other hand, if you don't see the value, dropping them completely is totally sane (although you might find out by doing so that you did have some users after all 😂).

@tianon
Copy link
Member Author

tianon commented Jun 4, 2025

CI failure is #19034 (haxe has Alpine 3.18 variants).

@francislavoie
Copy link
Contributor

ltsc2022 + ltsc2025 sounds reasonable to me, we'll try for that I suppose. We might drop it altogether at some point idk.

Copy link

github-actions bot commented Jun 6, 2025

Diff for 554eee1:
diff --git a/.external-pins/mcr.microsoft.com/windows/nanoserver___1809/bashbrew.json b/.external-pins/mcr.microsoft.com/windows/nanoserver___1809/bashbrew.json
deleted file mode 100644
index 07e369a..0000000
diff --git a/.external-pins/mcr.microsoft.com/windows/nanoserver___1809/manifest-sha256_58ab7a3ad3fce8815a8d4bc68220f8ae9060a5f51f78a929bef439d62670e2e0-config.json b/.external-pins/mcr.microsoft.com/windows/nanoserver___1809/manifest-sha256_58ab7a3ad3fce8815a8d4bc68220f8ae9060a5f51f78a929bef439d62670e2e0-config.json
deleted file mode 100644
index 76c00f9..0000000
diff --git a/.external-pins/mcr.microsoft.com/windows/nanoserver___1809/manifest-sha256_58ab7a3ad3fce8815a8d4bc68220f8ae9060a5f51f78a929bef439d62670e2e0.json b/.external-pins/mcr.microsoft.com/windows/nanoserver___1809/manifest-sha256_58ab7a3ad3fce8815a8d4bc68220f8ae9060a5f51f78a929bef439d62670e2e0.json
deleted file mode 100644
index 8d4d238..0000000
diff --git a/.external-pins/mcr.microsoft.com/windows/servercore___1809/bashbrew.json b/.external-pins/mcr.microsoft.com/windows/servercore___1809/bashbrew.json
deleted file mode 100644
index 7a5f7b8..0000000
diff --git a/.external-pins/mcr.microsoft.com/windows/servercore___1809/manifest-sha256_c508a91f808f5a3d22d407dfbe8abec29ade423dfb75ae1c1aff0a29d36d0ec9-config.json b/.external-pins/mcr.microsoft.com/windows/servercore___1809/manifest-sha256_c508a91f808f5a3d22d407dfbe8abec29ade423dfb75ae1c1aff0a29d36d0ec9-config.json
deleted file mode 100644
index c3ec4be..0000000
diff --git a/.external-pins/mcr.microsoft.com/windows/servercore___1809/manifest-sha256_c508a91f808f5a3d22d407dfbe8abec29ade423dfb75ae1c1aff0a29d36d0ec9.json b/.external-pins/mcr.microsoft.com/windows/servercore___1809/manifest-sha256_c508a91f808f5a3d22d407dfbe8abec29ade423dfb75ae1c1aff0a29d36d0ec9.json
deleted file mode 100644
index 06a1965..0000000
diff --git a/_bashbrew-cat b/_bashbrew-cat
index 7024e2e..919465e 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -17,13 +17,6 @@ Architectures: amd64, arm32v7, arm64v8
 GitCommit: 5b15afa744e6374bd547252dbc702ebe9aab4ddb
 Directory: 4.0/bullseye
 
-Tags: 4.0.5-windowsservercore-1809, 4.0-windowsservercore-1809
-SharedTags: 4.0.5-windowsservercore, 4.0-windowsservercore, 4.0.5, 4.0
-Architectures: windows-amd64
-GitCommit: c0367972017a7b87845bf33477e29b1fe64ccc4a
-Directory: 4.0/windowsservercore-1809
-Constraints: windowsservercore-1809
-
 Tags: 4.0.5-windowsservercore-ltsc2022, 4.0-windowsservercore-ltsc2022
 SharedTags: 4.0.5-windowsservercore, 4.0-windowsservercore, 4.0.5, 4.0
 Architectures: windows-amd64
@@ -47,13 +40,6 @@ Architectures: amd64, arm32v7, arm64v8
 GitCommit: 5b15afa744e6374bd547252dbc702ebe9aab4ddb
 Directory: 4.1/bullseye
 
-Tags: 4.1.5-windowsservercore-1809, 4.1-windowsservercore-1809
-SharedTags: 4.1.5-windowsservercore, 4.1-windowsservercore, 4.1.5, 4.1
-Architectures: windows-amd64
-GitCommit: c0367972017a7b87845bf33477e29b1fe64ccc4a
-Directory: 4.1/windowsservercore-1809
-Constraints: windowsservercore-1809
-
 Tags: 4.1.5-windowsservercore-ltsc2022, 4.1-windowsservercore-ltsc2022
 SharedTags: 4.1.5-windowsservercore, 4.1-windowsservercore, 4.1.5, 4.1
 Architectures: windows-amd64
@@ -82,13 +68,6 @@ Architectures: amd64, arm32v7, arm64v8
 GitCommit: 483c3e2b958d83239d03f4469ea9e745c0852326
 Directory: 4.2/bullseye
 
-Tags: 4.2.5-windowsservercore-1809, 4.2-windowsservercore-1809
-SharedTags: 4.2.5-windowsservercore, 4.2-windowsservercore, 4.2.5, 4.2
-Architectures: windows-amd64
-GitCommit: c0367972017a7b87845bf33477e29b1fe64ccc4a
-Directory: 4.2/windowsservercore-1809
-Constraints: windowsservercore-1809
-
 Tags: 4.2.5-windowsservercore-ltsc2022, 4.2-windowsservercore-ltsc2022
 SharedTags: 4.2.5-windowsservercore, 4.2-windowsservercore, 4.2.5, 4.2
 Architectures: windows-amd64
@@ -117,13 +96,6 @@ Architectures: amd64, arm32v7, arm64v8
 GitCommit: 483c3e2b958d83239d03f4469ea9e745c0852326
 Directory: 4.3/bullseye
 
-Tags: 4.3.6-windowsservercore-1809, 4.3-windowsservercore-1809
-SharedTags: 4.3.6-windowsservercore, 4.3-windowsservercore, 4.3.6, 4.3, latest
-Architectures: windows-amd64
-GitCommit: 03cdd3f2df8800aff8f28313181564ed9443dedd
-Directory: 4.3/windowsservercore-1809
-Constraints: windowsservercore-1809
-
 Tags: 4.3.6-windowsservercore-ltsc2022, 4.3-windowsservercore-ltsc2022
 SharedTags: 4.3.6-windowsservercore, 4.3-windowsservercore, 4.3.6, 4.3, latest
 Architectures: windows-amd64
diff --git a/_bashbrew-list b/_bashbrew-list
index ba0a90e..9ffebcf 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -4,7 +4,6 @@ haxe:4.0-alpine3.19
 haxe:4.0-alpine3.20
 haxe:4.0-bullseye
 haxe:4.0-windowsservercore
-haxe:4.0-windowsservercore-1809
 haxe:4.0-windowsservercore-ltsc2022
 haxe:4.0.5
 haxe:4.0.5-alpine
@@ -12,7 +11,6 @@ haxe:4.0.5-alpine3.19
 haxe:4.0.5-alpine3.20
 haxe:4.0.5-bullseye
 haxe:4.0.5-windowsservercore
-haxe:4.0.5-windowsservercore-1809
 haxe:4.0.5-windowsservercore-ltsc2022
 haxe:4.1
 haxe:4.1-alpine
@@ -20,7 +18,6 @@ haxe:4.1-alpine3.19
 haxe:4.1-alpine3.20
 haxe:4.1-bullseye
 haxe:4.1-windowsservercore
-haxe:4.1-windowsservercore-1809
 haxe:4.1-windowsservercore-ltsc2022
 haxe:4.1.5
 haxe:4.1.5-alpine
@@ -28,7 +25,6 @@ haxe:4.1.5-alpine3.19
 haxe:4.1.5-alpine3.20
 haxe:4.1.5-bullseye
 haxe:4.1.5-windowsservercore
-haxe:4.1.5-windowsservercore-1809
 haxe:4.1.5-windowsservercore-ltsc2022
 haxe:4.2
 haxe:4.2-alpine
@@ -37,7 +33,6 @@ haxe:4.2-alpine3.20
 haxe:4.2-bookworm
 haxe:4.2-bullseye
 haxe:4.2-windowsservercore
-haxe:4.2-windowsservercore-1809
 haxe:4.2-windowsservercore-ltsc2022
 haxe:4.2.5
 haxe:4.2.5-alpine
@@ -46,7 +41,6 @@ haxe:4.2.5-alpine3.20
 haxe:4.2.5-bookworm
 haxe:4.2.5-bullseye
 haxe:4.2.5-windowsservercore
-haxe:4.2.5-windowsservercore-1809
 haxe:4.2.5-windowsservercore-ltsc2022
 haxe:4.3
 haxe:4.3-alpine
@@ -55,7 +49,6 @@ haxe:4.3-alpine3.20
 haxe:4.3-bookworm
 haxe:4.3-bullseye
 haxe:4.3-windowsservercore
-haxe:4.3-windowsservercore-1809
 haxe:4.3-windowsservercore-ltsc2022
 haxe:4.3.6
 haxe:4.3.6-alpine
@@ -64,6 +57,5 @@ haxe:4.3.6-alpine3.20
 haxe:4.3.6-bookworm
 haxe:4.3.6-bullseye
 haxe:4.3.6-windowsservercore
-haxe:4.3.6-windowsservercore-1809
 haxe:4.3.6-windowsservercore-ltsc2022
 haxe:latest
diff --git a/_bashbrew-list-build-order b/_bashbrew-list-build-order
index 0588766..906c345 100644
--- a/_bashbrew-list-build-order
+++ b/_bashbrew-list-build-order
@@ -1,22 +1,18 @@
 haxe:4.0-alpine
 haxe:4.0-alpine3.19
 haxe:4.0-bullseye
-haxe:4.0-windowsservercore-1809
 haxe:4.0-windowsservercore-ltsc2022
 haxe:4.1-alpine
 haxe:4.1-alpine3.19
 haxe:4.1-bullseye
-haxe:4.1-windowsservercore-1809
 haxe:4.1-windowsservercore-ltsc2022
 haxe:4.2-alpine
 haxe:4.2-alpine3.19
 haxe:4.2-bookworm
 haxe:4.2-bullseye
-haxe:4.2-windowsservercore-1809
 haxe:4.2-windowsservercore-ltsc2022
 haxe:4.3-alpine
 haxe:4.3-alpine3.19
 haxe:4.3-bookworm
 haxe:4.3-bullseye
-haxe:4.3-windowsservercore-1809
 haxe:4.3-windowsservercore-ltsc2022
diff --git a/haxe_4.0-windowsservercore-1809/Dockerfile b/haxe_4.0-windowsservercore-1809/Dockerfile
deleted file mode 100644
index c5fc7e2..0000000
diff --git a/haxe_4.1-windowsservercore-1809/Dockerfile b/haxe_4.1-windowsservercore-1809/Dockerfile
deleted file mode 100644
index 8587c63..0000000
diff --git a/haxe_4.2-windowsservercore-1809/Dockerfile b/haxe_4.2-windowsservercore-1809/Dockerfile
deleted file mode 100644
index 431ae8a..0000000
diff --git a/haxe_4.3-windowsservercore-1809/Dockerfile b/haxe_4.3-windowsservercore-1809/Dockerfile
deleted file mode 100644
index 470a02c..0000000

Relevant Maintainers:

@tianon tianon merged commit a890364 into docker-library:master Jun 6, 2025
23 checks passed
@tianon tianon deleted the windows-2019 branch June 6, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider dropping Windows Server 2019 / 1809 support
3 participants