Implement OWNERS_ALIASES for sig-etcd roles #20233
Conversation
Signed-off-by: James Blair <mail@jamesblair.net>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - siyuanfoundation # Siyuan Zhang <sizhang@google.com> <physicsbug@gmail.com> | ||
| - sig-etcd-chairs # Defined in OWNERS_ALIASES | ||
| - sig-etcd-tech-leads # Defined in OWNERS_ALIASES | ||
| - fuweid # Wei Fu <fuweid89@gmail.com> |
There was a problem hiding this comment.
I think fuweid was nominated to be a TL
There was a problem hiding this comment.
I must have missed something here I don't see any discussion of this in #19572 (comment)?
|
SIG leads and a project maintainer/approver are two different roles. One being a sig lead doesn't mean he/she is a qualified project approver/maintainer. But I respect community manager (@jberkus ) 's opinion on this from governance prospective of point of view. One problem for this approach is that when a SIG lead step down, he/she will automatically lose the maintainer role. For the maintainers/approvers who gained their maintainer roles due to personal reputation & contribution to the project, we should consider adding them back to maintainers/approvers in such case if he/she wants. |
| - bdarnell # Ben Darnell <ben@bendarnell.com> | ||
| - fanminshi # Fanmin Shi <fanmin.shi@gmail.com> | ||
| - gyuho # Gyuho Lee <gyuhox@gmail.com> | ||
| - hexfusion # Sam Batschelet <sbatsche@redhat.com> | ||
| - heyitsanthony # Anthony Romano <romanoanthony061@gmail.com> | ||
| - jingyih # Jingyi Hu <jingyih@google.com> | ||
| - jpbetz # Joe Betz <jpbetz@google.com> | ||
| - mitake # Hitoshi Mitake <h.mitake@gmail.com> | ||
| - philips # Brandon Philips <brandon@ifup.org> | ||
| - ptabor # Piotr Tabor <piotr.tabor@gmail.com> | ||
| - wenjiaswe # Wenjia Zhang <wenjiazhang@google.com> <wenjia.swe@gmail.com> | ||
| - xiang90 # Xiang Li <xiangli.cs@gmail.com> |
There was a problem hiding this comment.
Why is your editor adding space padding here? Please remove this.
There was a problem hiding this comment.
Keeps the comments aligned, it looks better this way. You'll see what I mean when viewing the file without diff.
| - ahrtr # Benjamin Wang <benjamin.ahrtr@gmail.com> <benjamin.wang@broadcom.com> | ||
| - fuweid # Wei Fu <fuweid89@gmail.com> | ||
| - jmhbnz # James Blair <jablair@redhat.com> <mail@jamesblair.net> | ||
| - serathius # Marek Siarkowicz <siarkowicz@google.com> <marek.siarkowicz@gmail.com> | ||
| - spzala # Sahdev Zala <spzala@us.ibm.com> | ||
| reviewers: | ||
| - ivanvc # Ivan Valdes <ivan@vald.es> | ||
| - siyuanfoundation # Siyuan Zhang <sizhang@google.com> <physicsbug@gmail.com> | ||
| - sig-etcd-chairs # Defined in OWNERS_ALIASES | ||
| - sig-etcd-tech-leads # Defined in OWNERS_ALIASES | ||
| - fuweid # Wei Fu <fuweid89@gmail.com> |
|
@ahrtr this is handled in two different ways depending on the SIG. Some SIGs leave anyone who was added due to individual efforts in the OWNERs file, despite them being on teams as well. Other SIGs remove those folks, and remember to add them back when they rotate out of a leadership position. There's pros and cons with both ways of doing things, we just need to pick one. |
This pull request is a follow-up to #20203 adding a basic implementation of
OWNERS_ALIASESfor our Chair and Tech Lead roles.Currently our
OWNERSfile does not make it clear who holds a specific role with the sig, i.e. chair or tech lead. By adding an aliases file we can create arbitrary groupings that are publically auditable. This is the k8s approch to grouping GitHub users, refer to: https://www.kubernetes.dev/docs/guide/owners/#owners_aliasesPlease note - this pull request shifts @ivanvc and @siyuanfoundation from
reviewersection toapproverdue to their roles as co-chairs. We should have got to this update earlier when their promotions were announced.cc @etcd-io/maintainers-etcd