FIP-0107: Add API Behaviour Specifications and Migration Guide #1173
+110
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
requested review from
jennijuju,
anorth,
jsoares,
TippyFlitsUK,
momack2,
lanzafame and
dannyob
as code owners
BigLep
approved these changes
Jun 30, 2025
|
|
||
| **Option 1 - New API**: `ChainGetAllParentReceipts` - returns all receipts including those for implicit messages. This API would return the same results as `ChainGetParentReceipts` before activation of this FIP, but would include additional receipts for implicit messages after activation. | ||
|
|
||
| **Option 2 - v2 API**: As of the time of writing, development has begun on the Lotus v2 APIs. It is expected this will eventually lead to extension of [FRC-0104 Common Node APIs](https://github.com/filecoin-project/FIPs/blob/master/FRCs/frc-0104.md). This opportunity could be used to break APIs and introduce an options object that would allow optional inclusion of implicit messages. e.g. `ChainGetParentReceipts` could add a new paramter that would change the returned list to prevent filtering: `{ includeImplicits: true }`. |
There was a problem hiding this comment.
Good to have enumerated both options. I would bias towards this as a forcing function to engage and get usage on v2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the open questions in FIP-0107 regarding API behaviour for implicit messages by adding comprehensive specifications for how existing APIs will handle implicit messages while maintaining backward compatibility.
There is still one slightly open question in here, suggesting either the addition of a new
ChainGetAllParentReceiptsAPI or a new formChainGetParentReceiptson the currently under development /v2 that takes a new options parameter. We could come back and close that off once we've decided (it might depend on timing of this FIP).