Skip to content

fix: add missed arguments to string_attribute policy #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025

Conversation

vhatsura
Copy link
Contributor

fixes #1676

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2025

CLA assistant check
All committers have signed the CLA.

@vhatsura
Copy link
Contributor Author

vhatsura commented Jul 1, 2025

@petewall, @rlankfo, can you take a look into PR? Will be much appreciated

@petewall
Copy link
Collaborator

petewall commented Jul 4, 2025

Looks good to me, but I'd like @rlankfo 's eye on it, too.

Copy link
Member

@rlankfo rlankfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@petewall petewall merged commit 8a98d45 into grafana:main Jul 8, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missed support for invert_match and enabled_regex_matching in string_attribute tail sampling policy
4 participants