Skip to content

chore: stop using gatherer as a name #18144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

chore: stop using gatherer as a name #18144

merged 1 commit into from
Jul 3, 2025

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Jun 18, 2025 •
edited
Loading

What this PR does / why we need it:

This commit stops using gatherer as a name in the limits/frontend package. It does this for two reasons:

  1. Since we refactored how limits work, we no longer do what can be called as "gathering". It is more of a fanout.

  2. I've spent some time going back to more simple, obvious names, and I think client here explains enough what it does without the reader having to figure out what a "gatherer" is.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana
chore: stop using gatherer as a name
4406fb7 
This commit stops using gatherer as a name in the limits/frontend
package. It does this for two reasons:

1. Since we refactored how limits work, we no longer do what can
   be called as "gathering". It is more of a fanout.

2. I've spent some time going back to more simple, obvious names,
   and I think client here explains enough what it does without
   the reader having to figure out what a "gatherer" is.
@grobinson-grafana grobinson-grafana requested a review from a team as a code owner June 18, 2025 10:24
@grobinson-grafana grobinson-grafana merged commit 34b6bdc into main Jul 3, 2025
114 of 117 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/stop-using-gatherer-as-a-name branch July 3, 2025 10:30
andrejshapal pushed a commit to andrejshapal/loki that referenced this pull request Jul 3, 2025
@grobinson-grafana @andrejshapal
chore: stop using gatherer as a name (grafana#18144)
85e213d
andrejshapal added a commit to andrejshapal/loki that referenced this pull request Jul 3, 2025
@andrejshapal
Squashed commit of the following:
b11c266 
commit e0254aa
Merge: 37f0b49 95095ba
Author: J Stickler <julie.stickler@grafana.com>
Date:   Thu Jul 3 14:29:45 2025 -0400

    Merge branch 'main' into patch-1

commit 95095ba
Author: Robert Fratto <robertfratto@gmail.com>
Date:   Thu Jul 3 14:08:44 2025 -0400

    chore(arrowtest): add utilities to construct arrow.Record from test rows (grafana#18328)

commit 37f0b49
Merge: 321e48a 0ce3bdc
Author: Andrejs Šapals <njuhaandrej@gmail.com>
Date:   Thu Jul 3 20:15:42 2025 +0300

    Merge branch 'main' into patch-1

commit 0ce3bdc
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Jul 3 17:08:49 2025 +0000

    chore(deps): update kiwigrid/k8s-sidecar docker tag to v1.30.6 (main) (grafana#18323)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>

commit 321e48a
Author: Andrejs <njuhaandrej@gmail.com>
Date:   Thu Jul 3 19:45:12 2025 +0300

    Reverting README

commit 6dbab4a
Author: Andrejs <njuhaandrej@gmail.com>
Date:   Thu Jul 3 19:42:31 2025 +0300

    Reverting version

commit a074a68
Author: Andrejs <njuhaandrej@gmail.com>
Date:   Thu Jul 3 19:42:07 2025 +0300

    Reverting version

commit 68e4a23
Author: Andrejs <njuhaandrej@gmail.com>
Date:   Thu Jul 3 19:41:34 2025 +0300

    Reverting version

commit 9d9c046
Merge: 33776d8 9c3d86b
Author: Andrejs Šapals <njuhaandrej@gmail.com>
Date:   Thu Jul 3 19:40:06 2025 +0300

    Merge branch 'main' into patch-1

commit 33776d8
Author: Robert Fratto <robertfratto@gmail.com>
Date:   Thu Jul 3 12:04:15 2025 -0400

    chore(dataobj): cut logs section based on uncompressed size (grafana#18329)

commit 5bdcc39
Author: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Date:   Thu Jul 3 20:03:18 2025 +0530

    feat(compactor HS): refactor interfaces and build a link between delete requests manager and compactor for HS of compactor (grafana#18326)

    Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
    Co-authored-by: Paul Rogers <129207811+paul1r@users.noreply.github.com>

commit 3c9e763
Author: Ashwanth <iamashwanth@gmail.com>
Date:   Thu Jul 3 18:52:59 2025 +0530

    chore(dataobj): avoid reading a predicate column more than once (grafana#18324)

commit bf5cc2d
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Jul 3 10:41:59 2025 +0000

    chore(deps): update dependency vite to v7.0.1 (main) (grafana#18322)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 85e213d
Author: George Robinson <george.robinson@grafana.com>
Date:   Thu Jul 3 11:30:22 2025 +0100

    chore: stop using gatherer as a name (grafana#18144)

commit 3f19ee4
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Jul 3 04:59:26 2025 +0000

    chore(deps): update terraform aws to ~> 6.2.0 (main) (grafana#18318)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 9662cc2
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Jul 3 04:59:06 2025 +0000

    fix(deps): update module github.com/docker/docker to v28.3.1+incompatible (main) (grafana#18317)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 4f39c44
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Jul 3 04:57:16 2025 +0000

    fix(deps): update dependency zod to v3.25.71 (main) (grafana#18316)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit f414744
Author: Trevor Whitney <trevorjwhitney@gmail.com>
Date:   Wed Jul 2 17:05:37 2025 -0600

    feat: return metric query partial results for drilldown (grafana#18286)

commit ab0527e
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Jul 2 21:37:43 2025 +0000

    fix(deps): update dependency zod to v3.25.69 (main) (grafana#18315)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit dcf8409
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Jul 2 19:16:31 2025 +0000

    fix(deps): update module github.com/aws/aws-sdk-go-v2/service/s3 to v1.83.0 (main) (grafana#18312)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit d6f8a74
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Jul 2 19:13:33 2025 +0000

    fix(deps): update dependency zod to v3.25.68 (main) (grafana#18311)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 4169e5f
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Jul 2 17:40:08 2025 +0000

    fix(deps): update module google.golang.org/api to v0.240.0 (main) (grafana#18310)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 5df73cb
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Jul 2 17:36:41 2025 +0000

    chore(deps): update kiwigrid/k8s-sidecar docker tag to v1.30.5 (main) (grafana#18204)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>

commit 96f85c1
Author: Ilia Lazebnik <Ilia.lazebnik@gmail.com>
Date:   Wed Jul 2 16:30:58 2025 +0300

    feat(helm): add PDB for patternIngester (grafana#17058)

    Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
    Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>

commit 7e5e0c3
Author: Lukas Juozas Janusaitis <74900682+LukoJy3D@users.noreply.github.com>
Date:   Wed Jul 2 16:13:05 2025 +0300

    feat(helm): add readiness probe for memcached (grafana#15609)

    Signed-off-by: Lukas Juozas Janusaitis <74900682+LukoJy3D@users.noreply.github.com>
    Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de>

commit 9c3d86b
Author: Robert Fratto <robertfratto@gmail.com>
Date:   Thu Jul 3 12:04:15 2025 -0400

    chore(dataobj): cut logs section based on uncompressed size (grafana#18329)

commit 3646607
Author: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Date:   Thu Jul 3 20:03:18 2025 +0530

    feat(compactor HS): refactor interfaces and build a link between delete requests manager and compactor for HS of compactor (grafana#18326)

    Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
    Co-authored-by: Paul Rogers <129207811+paul1r@users.noreply.github.com>

commit 5c02493
Author: Ashwanth <iamashwanth@gmail.com>
Date:   Thu Jul 3 18:52:59 2025 +0530

    chore(dataobj): avoid reading a predicate column more than once (grafana#18324)

commit 112c6b1
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Jul 3 10:41:59 2025 +0000

    chore(deps): update dependency vite to v7.0.1 (main) (grafana#18322)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 34b6bdc
Author: George Robinson <george.robinson@grafana.com>
Date:   Thu Jul 3 11:30:22 2025 +0100

    chore: stop using gatherer as a name (grafana#18144)

commit 147ca53
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Jul 3 04:59:26 2025 +0000

    chore(deps): update terraform aws to ~> 6.2.0 (main) (grafana#18318)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit b25f1b1
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Jul 3 04:59:06 2025 +0000

    fix(deps): update module github.com/docker/docker to v28.3.1+incompatible (main) (grafana#18317)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit c29a78a
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Jul 3 04:57:16 2025 +0000

    fix(deps): update dependency zod to v3.25.71 (main) (grafana#18316)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit c0c2265
Author: Trevor Whitney <trevorjwhitney@gmail.com>
Date:   Wed Jul 2 17:05:37 2025 -0600

    feat: return metric query partial results for drilldown (grafana#18286)

commit 6df3403
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Jul 2 21:37:43 2025 +0000

    fix(deps): update dependency zod to v3.25.69 (main) (grafana#18315)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 927342e
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Jul 2 19:16:31 2025 +0000

    fix(deps): update module github.com/aws/aws-sdk-go-v2/service/s3 to v1.83.0 (main) (grafana#18312)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit c95ef4c
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Jul 2 19:13:33 2025 +0000

    fix(deps): update dependency zod to v3.25.68 (main) (grafana#18311)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 255ec56
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Jul 2 17:40:08 2025 +0000

    fix(deps): update module google.golang.org/api to v0.240.0 (main) (grafana#18310)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit a76ff15
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Jul 2 17:36:41 2025 +0000

    chore(deps): update kiwigrid/k8s-sidecar docker tag to v1.30.5 (main) (grafana#18204)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>

commit 7fad38d
Author: Ilia Lazebnik <Ilia.lazebnik@gmail.com>
Date:   Wed Jul 2 16:30:58 2025 +0300

    feat(helm): add PDB for patternIngester (grafana#17058)

    Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
    Co-authored-by: Jay Clifford <45856600+Jayclifford345@users.noreply.github.com>

commit 6ed1461
Author: Lukas Juozas Janusaitis <74900682+LukoJy3D@users.noreply.github.com>
Date:   Wed Jul 2 16:13:05 2025 +0300

    feat(helm): add readiness probe for memcached (grafana#15609)

    Signed-off-by: Lukas Juozas Janusaitis <74900682+LukoJy3D@users.noreply.github.com>
    Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de>
andrejshapal pushed a commit to andrejshapal/loki that referenced this pull request Jul 8, 2025
@grobinson-grafana @andrejshapal
chore: stop using gatherer as a name (grafana#18144)
58a98ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grobinson-grafana @periklis