Skip to content

Conversation

andrewchointrepid
Copy link

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

DMS Serverless tasks, when modified in-place due to a config change in Terraform, will always fail in the Terraform Apply due to the change in DMS state to Modifying and then being attempted to changed immediately to Start. The Terraform Apply must wait for the Modifying state to end first.

Relations

Closes #35650

Output from Acceptance Testing

% make testacc TESTS=TestAccDMSReplicationConfig_update PKG=dms

...

@andrewchointrepid andrewchointrepid requested a review from a team as a code owner June 19, 2025 06:38
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link
Contributor

github-actions bot commented Jun 19, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dms Issues and PRs that pertain to the dms service. size/S Managed by automation to categorize the size of a PR. labels Jun 19, 2025
@andrewchointrepid andrewchointrepid changed the title Fix in-place modification of DMS replication config by adding a wait fix: in-place modification of DMS replication config by adding a wait Jun 19, 2025
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 19, 2025
Copy link

@SachithraM-Intrepid SachithraM-Intrepid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktalele-rescale
Copy link

ktalele-rescale commented Aug 15, 2025

Thankyou for fixing this! Any idea when this will make it into a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/dms Issues and PRs that pertain to the dms service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DMS aws_dms_replication_config resource cannot be updated from a running or stopped state and must almost always be recreated
4 participants