Add resource identity to aws_lb_listener_rule
#43155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
github-actions
bot
added
prioritized
breathingdust
force-pushed
the
f-ri-lb-listener-rule
branch
from
891f7d1 to
a7548cc
Compare
|
Tests passing after rebase. % make testacc PKG=elbv2 TESTS=TestAccELBV2ListenerRule_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2ListenerRule_' -timeout 360m -vet=off
2025/07/16 16:26:31 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/16 16:26:31 Initializing Terraform AWS Provider (SDKv2-style)...
--- PASS: TestAccELBV2ListenerRule_ConditionHTTPHeader_invalid (3.87s)
=== CONT TestAccELBV2ListenerRule_conditionSourceIP
--- PASS: TestAccELBV2ListenerRule_tags_null (237.29s)
=== CONT TestAccELBV2ListenerRule_conditionQueryString
--- PASS: TestAccELBV2ListenerRule_tags_AddOnUpdate (240.25s)
=== CONT TestAccELBV2ListenerRule_conditionPathPattern
--- PASS: TestAccELBV2ListenerRule_tags_DefaultTags_emptyProviderOnlyTag (241.02s)
=== CONT TestAccELBV2ListenerRule_conditionHTTPRequestMethod
--- PASS: TestAccELBV2ListenerRule_tags_DefaultTags_emptyResourceTag (249.01s)
=== CONT TestAccELBV2ListenerRule_conditionAttributesCount
--- PASS: TestAccELBV2ListenerRule_tags_EmptyMap (249.50s)
=== CONT TestAccELBV2ListenerRule_conditionHTTPHeader
--- PASS: TestAccELBV2ListenerRule_Identity_Basic (254.83s)
=== CONT TestAccELBV2ListenerRule_conditionHostHeader
--- PASS: TestAccELBV2ListenerRule_conditionMultiple (260.26s)
=== CONT TestAccELBV2ListenerRule_Identity_ExistingResource
--- PASS: TestAccELBV2ListenerRule_tags_EmptyTag_OnUpdate_Replace (260.74s)
=== CONT TestAccELBV2ListenerRule_tags
--- PASS: TestAccELBV2ListenerRule_conditionAttributesCount (27.83s)
=== CONT TestAccELBV2ListenerRule_Identity_RegionOverride
--- PASS: TestAccELBV2ListenerRule_conditionUpdateMultiple (282.00s)
=== CONT TestAccELBV2ListenerRule_EmptyAction
=== RUN TestAccELBV2ListenerRule_EmptyAction/forward
=== PAUSE TestAccELBV2ListenerRule_EmptyAction/forward
=== RUN TestAccELBV2ListenerRule_EmptyAction/authenticate-oidc
=== PAUSE TestAccELBV2ListenerRule_EmptyAction/authenticate-oidc
=== RUN TestAccELBV2ListenerRule_EmptyAction/authenticate-cognito
=== PAUSE TestAccELBV2ListenerRule_EmptyAction/authenticate-cognito
=== RUN TestAccELBV2ListenerRule_EmptyAction/redirect
=== PAUSE TestAccELBV2ListenerRule_EmptyAction/redirect
=== RUN TestAccELBV2ListenerRule_EmptyAction/fixed-response
=== PAUSE TestAccELBV2ListenerRule_EmptyAction/fixed-response
=== CONT TestAccELBV2ListenerRule_fixedResponse
--- PASS: TestAccELBV2ListenerRule_tags_DefaultTags_updateToProviderOnly (286.11s)
=== CONT TestAccELBV2ListenerRule_redirectWithTargetGroupARN
--- PASS: TestAccELBV2ListenerRule_tags_DefaultTags_updateToResourceOnly (291.79s)
=== CONT TestAccELBV2ListenerRule_Action_defaultOrder
--- PASS: TestAccELBV2ListenerRule_conditionSourceIP (289.85s)
=== CONT TestAccELBV2ListenerRule_oidc
--- PASS: TestAccELBV2ListenerRule_Action_specifyOrder (294.50s)
=== CONT TestAccELBV2ListenerRule_cognito
--- PASS: TestAccELBV2ListenerRule_ActionForward_TargetGroupARNToForwardBlock_WeightAndStickiness (297.26s)
=== CONT TestAccELBV2ListenerRule_priority
--- PASS: TestAccELBV2ListenerRule_tags_EmptyTag_OnUpdate_Add (307.33s)
=== CONT TestAccELBV2ListenerRule_ActionForward_ForwardBlock_RemoveAction
--- PASS: TestAccELBV2ListenerRule_tags_EmptyTag_OnCreate (313.81s)
=== CONT TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew
--- PASS: TestAccELBV2ListenerRule_conditionUpdateMixed (331.47s)
=== CONT TestAccELBV2ListenerRule_updateRulePriority
--- PASS: TestAccELBV2ListenerRule_tags_DefaultTags_overlapping (352.63s)
=== CONT TestAccELBV2ListenerRule_updateFixedResponse
--- PASS: TestAccELBV2ListenerRule_tags_DefaultTags_nonOverlapping (404.28s)
=== CONT TestAccELBV2ListenerRule_ActionForward_IgnoreFields
--- PASS: TestAccELBV2ListenerRule_tags_DefaultTags_providerOnly (449.21s)
=== CONT TestAccELBV2ListenerRule_basic
--- PASS: TestAccELBV2ListenerRule_conditionPathPattern (218.29s)
=== CONT TestAccELBV2ListenerRule_ActionForward_ForwardBlock_RemoveStickiness
--- PASS: TestAccELBV2ListenerRule_conditionQueryString (229.19s)
=== CONT TestAccELBV2ListenerRule_ActionForward_ForwardBlock_AddStickiness
--- PASS: TestAccELBV2ListenerRule_conditionHTTPRequestMethod (225.46s)
=== CONT TestAccELBV2ListenerRule_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccELBV2ListenerRule_conditionHTTPHeader (221.34s)
=== CONT TestAccELBV2ListenerRule_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccELBV2ListenerRule_conditionHostHeader (221.34s)
=== CONT TestAccELBV2ListenerRule_backwardsCompatibility
--- PASS: TestAccELBV2ListenerRule_Action_defaultOrder (224.26s)
=== CONT TestAccELBV2ListenerRule_redirect
--- PASS: TestAccELBV2ListenerRule_fixedResponse (234.09s)
=== CONT TestAccELBV2ListenerRule_updateForwardBasic
--- PASS: TestAccELBV2ListenerRule_Identity_RegionOverride (239.33s)
=== CONT TestAccELBV2ListenerRule_forwardWeighted
--- PASS: TestAccELBV2ListenerRule_oidc (224.99s)
=== CONT TestAccELBV2ListenerRule_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccELBV2ListenerRule_cognito (230.09s)
=== CONT TestAccELBV2ListenerRule_tags_ComputedTag_OnCreate
--- PASS: TestAccELBV2ListenerRule_Identity_ExistingResource (266.33s)
=== CONT TestAccELBV2ListenerRule_ActionForward_ForwardBlockToTargetGroupARN_WeightAndStickiness
--- PASS: TestAccELBV2ListenerRule_tags (278.52s)
=== CONT TestAccELBV2ListenerRule_ActionForward_ForwardBlock_AddAction
--- PASS: TestAccELBV2ListenerRule_ActionForward_ForwardBlock_RemoveAction (246.59s)
=== CONT TestAccELBV2ListenerRule_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccELBV2ListenerRule_redirectWithTargetGroupARN (274.91s)
=== CONT TestAccELBV2ListenerRule_disappears
--- PASS: TestAccELBV2ListenerRule_updateRulePriority (242.28s)
=== CONT TestAccELBV2ListenerRule_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccELBV2ListenerRule_updateFixedResponse (240.19s)
=== CONT TestAccELBV2ListenerRule_ActionForward_ForwardBlockToTargetGroupARN_NoChanges
--- PASS: TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew (281.14s)
=== CONT TestAccELBV2ListenerRule_Action_actionDisappears
--- PASS: TestAccELBV2ListenerRule_ActionForward_IgnoreFields (211.74s)
=== CONT TestAccELBV2ListenerRule_ActionForward_TargetGroupARNToForwardBlock_NoChanges
--- PASS: TestAccELBV2ListenerRule_priority (361.94s)
=== CONT TestAccELBV2ListenerRule_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccELBV2ListenerRule_basic (239.81s)
=== CONT TestAccELBV2ListenerRule_EmptyAction/forward
=== CONT TestAccELBV2ListenerRule_EmptyAction/redirect
=== CONT TestAccELBV2ListenerRule_EmptyAction/fixed-response
=== CONT TestAccELBV2ListenerRule_EmptyAction/authenticate-cognito
=== CONT TestAccELBV2ListenerRule_EmptyAction/authenticate-oidc
--- PASS: TestAccELBV2ListenerRule_backwardsCompatibility (221.29s)
--- PASS: TestAccELBV2ListenerRule_EmptyAction (0.00s)
--- PASS: TestAccELBV2ListenerRule_EmptyAction/forward (1.73s)
--- PASS: TestAccELBV2ListenerRule_EmptyAction/redirect (1.75s)
--- PASS: TestAccELBV2ListenerRule_EmptyAction/fixed-response (1.82s)
--- PASS: TestAccELBV2ListenerRule_EmptyAction/authenticate-cognito (1.70s)
--- PASS: TestAccELBV2ListenerRule_EmptyAction/authenticate-oidc (1.69s)
--- PASS: TestAccELBV2ListenerRule_ActionForward_ForwardBlock_RemoveStickiness (241.09s)
--- PASS: TestAccELBV2ListenerRule_ActionForward_ForwardBlock_AddStickiness (239.13s)
--- PASS: TestAccELBV2ListenerRule_tags_ComputedTag_OnUpdate_Add (248.63s)
--- PASS: TestAccELBV2ListenerRule_tags_IgnoreTags_Overlap_ResourceTag (256.59s)
--- PASS: TestAccELBV2ListenerRule_tags_DefaultTags_nullNonOverlappingResourceTag (221.31s)
--- PASS: TestAccELBV2ListenerRule_updateForwardBasic (242.65s)
--- PASS: TestAccELBV2ListenerRule_ActionForward_ForwardBlockToTargetGroupARN_WeightAndStickiness (235.96s)
--- PASS: TestAccELBV2ListenerRule_forwardWeighted (261.87s)
--- PASS: TestAccELBV2ListenerRule_disappears (221.81s)
--- PASS: TestAccELBV2ListenerRule_ActionForward_ForwardBlock_AddAction (245.56s)
--- PASS: TestAccELBV2ListenerRule_tags_ComputedTag_OnUpdate_Replace (241.14s)
--- PASS: TestAccELBV2ListenerRule_tags_DefaultTags_nullOverlappingResourceTag (222.44s)
--- PASS: TestAccELBV2ListenerRule_tags_ComputedTag_OnCreate (281.07s)
--- PASS: TestAccELBV2ListenerRule_Action_actionDisappears (228.74s)
--- PASS: TestAccELBV2ListenerRule_ActionForward_ForwardBlockToTargetGroupARN_NoChanges (237.29s)
--- PASS: TestAccELBV2ListenerRule_ActionForward_TargetGroupARNToForwardBlock_NoChanges (227.46s)
--- PASS: TestAccELBV2ListenerRule_tags_IgnoreTags_Overlap_DefaultTag (243.39s)
--- PASS: TestAccELBV2ListenerRule_redirect (433.64s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 957.476s |
Also adds the `@Testing(preIdentityVersion="")` annotation to properly generate the `_ExistingResource` identity test. ```console % make testacc PKG=elbv2 TESTS=TestAccELBV2ListenerRule_Identity make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.24.5 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2ListenerRule_Identity' -timeout 360m -vet=off 2025/07/16 16:10:56 Creating Terraform AWS Provider (SDKv2-style)... 2025/07/16 16:10:56 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccELBV2ListenerRule_Identity_Basic === PAUSE TestAccELBV2ListenerRule_Identity_Basic === RUN TestAccELBV2ListenerRule_Identity_RegionOverride === PAUSE TestAccELBV2ListenerRule_Identity_RegionOverride === RUN TestAccELBV2ListenerRule_Identity_ExistingResource === PAUSE TestAccELBV2ListenerRule_Identity_ExistingResource === CONT TestAccELBV2ListenerRule_Identity_Basic === CONT TestAccELBV2ListenerRule_Identity_ExistingResource === CONT TestAccELBV2ListenerRule_Identity_RegionOverride --- PASS: TestAccELBV2ListenerRule_Identity_RegionOverride (218.73s) --- PASS: TestAccELBV2ListenerRule_Identity_Basic (227.14s) --- PASS: TestAccELBV2ListenerRule_Identity_ExistingResource (253.18s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 259.235s ```
jar-b
force-pushed
the
f-ri-lb-listener-rule
branch
from
0bc9c2c to
0fd252b
Compare
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
|
This functionality has been released in v6.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Adds resource identity to
aws_lb_listener_rule. This is of typeArnIdentityRelations
Relates #42984
References
Output from Acceptance Testing
I don't believe the post-test destroy failure is related to change.