Skip to content

Clarify availability of AOP on non-raft backends #31062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raskchanky
Copy link
Collaborator

Description

This updates the docs to clarify that AOP isn't available unless you're using raft.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@raskchanky raskchanky requested review from a team as code owners June 20, 2025 20:51
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 20, 2025
@raskchanky raskchanky added website Code changes specifically for the docs website pr/no-changelog pr/no-milestone and removed hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Jun 20, 2025
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@@ -75,8 +75,8 @@ to avoid replication lag.

Write overload protection was added in Vault Enterprise 1.17 as a beta feature
and was disabled by default. Since Vault 1.18.0 it is enabled by default only
when using Raft Integrated Storage. Adaptive overload protection is disabled by
default for Consul and other storage backends.
when using Integrated Storage. Adaptive overload protection is not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
when using Integrated Storage. Adaptive overload protection is not
when using integrated storage. Adaptive overload protection is not

Style correction: reserve capitalization for product and pseudo-product names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.20.x pr/no-changelog pr/no-milestone website Code changes specifically for the docs website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants