Skip to content

UI: Address swagger invalid color contrast #31080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

lane-wetmore
Copy link
Contributor

@lane-wetmore lane-wetmore commented Jun 24, 2025

Description

This PR fixes insufficient color-contrast swagger ui page.

Updates:

  • Version badge colors
  • Link text color
  • GET, POST, PATCH, DELETE + DEPRECATED operation backgrounds

Before:

image image image

After:

image image image

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@lane-wetmore lane-wetmore added this to the 1.21.0-rc1 milestone Jun 24, 2025
@lane-wetmore lane-wetmore requested a review from a team as a code owner June 24, 2025 17:46
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 24, 2025
@lane-wetmore lane-wetmore changed the base branch from main to ui/VAULT-32403-disabled-interactive-element June 24, 2025 17:48
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@lane-wetmore lane-wetmore force-pushed the ui/VAULT-32403-disabled-interactive-element branch from 2acb3db to acd9e05 Compare June 24, 2025 21:48
@lane-wetmore lane-wetmore changed the base branch from ui/VAULT-32403-disabled-interactive-element to main June 25, 2025 14:53
@lane-wetmore lane-wetmore force-pushed the ui/VAULT-32402-swagger-invalid-color-contrast branch from 3b15e39 to 786eb15 Compare June 25, 2025 14:54
@lane-wetmore lane-wetmore merged commit c01874d into main Jun 30, 2025
32 of 33 checks passed
@lane-wetmore lane-wetmore deleted the ui/VAULT-32402-swagger-invalid-color-contrast branch June 30, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants