-
Notifications
You must be signed in to change notification settings - Fork 121
[search-input-nav] Fix search icon overlap #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@Ayushmore1214 @vishalvivekm @vr-varad Please review |
Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com>
This is a good item to add to the weekly Websites meeting agenda. You can add this item in the doc, attend, and present it. Meeting details at https://meet.layer5.io. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job , looks good to go @ShirshenduR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Would you mind changing color of cross compatible to the dark mode same as the search icon.
@vr-varad The native browser clear (cross) button in search box cannot have its color changed via CSS—browsers ignore the color property. For a custom color, we need to hide the native button and implement our own clear button so should I proceed with it? @miacycle |
Never Mind. |
@vr-varad @zihanKuang If everything is good. can you merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍Thank you!
Notes for Reviewers
This PR fixes #622
Signed commits