Skip to content

[search-input-nav] Fix search icon overlap #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025

Conversation

ShirshenduR
Copy link
Contributor

Notes for Reviewers

This PR fixes #622

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com>
Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 8a50718
🔍 Latest deploy log https://app.netlify.com/projects/bejewelled-pegasus-b0ce81/deploys/6868bb3c6f53df0009877741
😎 Deploy Preview https://deploy-preview-627--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ShirshenduR
Copy link
Contributor Author

ShirshenduR commented Jul 3, 2025

@Ayushmore1214 @vishalvivekm @vr-varad Please review

Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com>
@leecalcote
Copy link
Member

This is a good item to add to the weekly Websites meeting agenda. You can add this item in the doc, attend, and present it. Meeting details at https://meet.layer5.io.

Copy link
Contributor

@Ayushmore1214 Ayushmore1214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job , looks good to go @ShirshenduR

Copy link
Contributor

@vr-varad vr-varad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Would you mind changing color of cross compatible to the dark mode same as the search icon.

@ShirshenduR
Copy link
Contributor Author

ShirshenduR commented Jul 7, 2025

LGTM Would you mind changing color of cross compatible to the dark mode same as the search icon.

@vr-varad The native browser clear (cross) button in search box cannot have its color changed via CSS—browsers ignore the color property. For a custom color, we need to hide the native button and implement our own clear button so should I proceed with it? @miacycle

@zihanKuang zihanKuang requested a review from vr-varad July 7, 2025 16:49
@vr-varad
Copy link
Contributor

vr-varad commented Jul 7, 2025

he native browser clear (cross) button in search box cannot have its color changed via CSS—browsers ignore the color property. For a custom color, we need to hide the native button and implement our own clear button so should I

Never Mind.

@ShirshenduR
Copy link
Contributor Author

ShirshenduR commented Jul 7, 2025

@vr-varad @zihanKuang If everything is good. can you merge the PR.

Copy link
Contributor

@zihanKuang zihanKuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍Thank you!

@zihanKuang zihanKuang merged commit f21a655 into layer5io:master Jul 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Bar content Overlapping
7 participants