[Shopify] Connector - Market Catalogs #28742
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link. |
|
This PR is moved to BcApps: microsoft/BCApps#4378 |
onbuyuka
added a commit
to microsoft/BCApps
that referenced
this pull request
Aug 12, 2025
This PR is moved from microsoft/ALAppExtensions#28742 <!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> **Market Catalogs implementation:** - Page "Shop Card" - added new action to open Market Catalogs for the shop - Table 30152 "Shpfy Catalog" - new fields "Catalog Type", "Currency Code" added - Page 30159 "Shpfy Catalogs": Changed page caption to 'Shopify B2B Catalogs' Added functioanlity to set Catalog Type Added filtering OnOpenPage - New page 30171 "Shpfy Market Catalogs" is created with the filter to show only Market Catalogs - Report 30116 "Shpfy Sync Catalog Prices": Adjusted current functionality to be compatible for different kind of Shopify Catalogs (Company, Market) - Report 30115 "Shpfy Sync Catalogs" Adjusted current functionality to be compable for different kind of Shopify Catalogs (Company, Market) - New enum 30167 "Shpfy Catalog Type" created to classify different kind of Shopify catalogs (Company, Market) - Codeunit "Shpfy Catalog API": Implemented new procedures GetMarketCatalogs(), ExtractShopifyMarketCatalogs(), GetMarketsLinkedToCatalog(), ExtractMarketsLinkedToCatalog() Adjusted GetMarketCatalogProductsURL() procedure to get Shopify URL for market catalogs products - Codeunit 30101 "Shpfy Background Syncs" - extended internal procedure CatalogPricesSync() to manage market catalogs prices - Codeunit 30182 "Shpfy Product Price Calc." - Added additional functionality for procedure CreateTempSalesHeader() to set "Currency Code" from Market Catalog - Codeunit 30106 "Shpfy Upgrade Mgt." - Added procedure to update existing catalogs by assigning Catalog Type 'Company' New GraphQLs created: - codeunit 30400 "Shpfy GQL Market Catalogs" (enum 30111 "Shpfy GraphQL Type"::GetMarketCatalogs) (incl. Currency Code) - codeunit 30401 "Shpfy GQL NextMarketCatalogs" (enum 30111 "Shpfy GraphQL Type"::GetNextMarketCatalogs) (incl. Currency Code) - codeunit 30402 "Shpfy GQL Catalog Markets" (enum 30402 "Shpfy GraphQL Type"::GetMarketCatalogs) - codeunit 30403 "Shpfy GQL NextCatalogMarkets" - Enum 30111 "Shpfy GraphQL Type" - added new Enum values as new implementation for Market Catalogs codeunit 30103 "Shpfy Communication Mgt." - Increased API Version to 2025-04 New automated Tests (codeunit 139542 "Shpfy Market Catalog API Test"): - Extract Shopify Market Catalogs **Other Fixes:** - Proceudre GetCatalogProductsURL() (codeunit "Shpfy Catalog API") doesn't work properly - returns incorrect Shop Name due to TrimStart function behavior. Switched to Replace function. - Proceudre ExtractShopifyCatalogs() (codeunit "Shpfy Catalog API") doesn't work properly - it doesn't update catalogs information because Modify() is after FindFirst() #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#581129](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/581129) --------- Co-authored-by: justaszaksauskas <justas.zaksauskas@companial.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does not have a related issue as it's part of the delivery for development agreed directly with @AndreiPanko
Market Catalogs implementation:
Changed page caption to 'Shopify B2B Catalogs'
Added functioanlity to set Catalog Type
Added filtering OnOpenPage
Adjusted current functionality to be compatible for different kind of Shopify Catalogs (Company, Market)
Adjusted current functionality to be compable for different kind of Shopify Catalogs (Company, Market)
Implemented new procedures GetMarketCatalogs(), ExtractShopifyMarketCatalogs(), GetMarketsLinkedToCatalog(), ExtractMarketsLinkedToCatalog()
Adjusted GetMarketCatalogProductsURL() procedure to get Shopify URL for market catalogs products
New GraphQLs created:
codeunit 30103 "Shpfy Communication Mgt." - Increased API Version to 2025-04
New automated Tests (codeunit 139542 "Shpfy Market Catalog API Test"):
- Extract Shopify Market Catalogs
Other Fixes: